2015-11-05 16:02:43

by Corentin Labbe

Subject: [PATCH] gpio: syscon: fix a possible NULL dereference

of_match_device could return NULL, and so cause a NULL pointer
dereference later at line 199:
priv->flags = of_id->data;

Reported-by: coverity (CID 1324140)
Signed-off-by: LABBE Corentin <[email protected]>
---
drivers/gpio/gpio-syscon.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/gpio/gpio-syscon.c b/drivers/gpio/gpio-syscon.c
index 045a952..e673c58 100644
--- a/drivers/gpio/gpio-syscon.c
+++ b/drivers/gpio/gpio-syscon.c
@@ -192,6 +192,9 @@ static int syscon_gpio_probe(struct platform_device *pdev)
struct device_node *np = dev->of_node;
int ret;

+ if (!of_id)
+ return -ENODEV;
+
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
--
2.4.10

2015-11-09 00:23:34

by Alexandre Courbot

Subject: Re: [PATCH] gpio: syscon: fix a possible NULL dereference

On Fri, Nov 6, 2015 at 1:02 AM, LABBE Corentin
<[email protected]> wrote:
> of_match_device could return NULL, and so cause a NULL pointer
> dereference later at line 199:
> priv->flags = of_id->data;
>
> Reported-by: coverity (CID 1324140)
> Signed-off-by: LABBE Corentin <[email protected]>

Same (optional) suggestion as the 74xx-mmio patch.

Reviewed-by: Alexandre Courbot <[email protected]>

2015-11-17 11:02:00

by Linus Walleij

Subject: Re: [PATCH] gpio: syscon: fix a possible NULL dereference

On Thu, Nov 5, 2015 at 5:02 PM, LABBE Corentin
<[email protected]> wrote:

> of_match_device could return NULL, and so cause a NULL pointer
> dereference later at line 199:
> priv->flags = of_id->data;
>
> Reported-by: coverity (CID 1324140)
> Signed-off-by: LABBE Corentin <[email protected]>

Patch applied with Alexandre's review tag.

Yours,
Linus Walleij