2023-11-21 09:11:54

by TY_Chang[張子逸]

Subject: [PATCH] pinctrl: realtek: Fix logical error when finding descriptor

The pin descriptor should be returned if the name has been found in the
descriptor table. Remove the negation in the if statement for accurate
retrieval.

Fixes: e99ce78030db ("pinctrl: realtek: Add common pinctrl driver for Realtek DHC RTD SoCs")
Signed-off-by: Tzuyi Chang <[email protected]>
---
drivers/pinctrl/realtek/pinctrl-rtd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pinctrl/realtek/pinctrl-rtd.c b/drivers/pinctrl/realtek/pinctrl-rtd.c
index 9c7a1af4ba69..208896593b61 100644
--- a/drivers/pinctrl/realtek/pinctrl-rtd.c
+++ b/drivers/pinctrl/realtek/pinctrl-rtd.c
@@ -146,7 +146,7 @@ static int rtd_pinctrl_get_function_groups(struct pinctrl_dev *pcdev,

static const struct rtd_pin_desc *rtd_pinctrl_find_mux(struct rtd_pinctrl *data, unsigned int pin)
{
- if (!data->info->muxes[pin].name)
+ if (data->info->muxes[pin].name)
return &data->info->muxes[pin];

return NULL;
@@ -249,7 +249,7 @@ static const struct pinctrl_pin_desc
static const struct rtd_pin_config_desc
*rtd_pinctrl_find_config(struct rtd_pinctrl *data, unsigned int pin)
{
- if (!data->info->configs[pin].name)
+ if (data->info->configs[pin].name)
return &data->info->configs[pin];

return NULL;
--
2.42.0

2023-11-24 09:40:10

by Linus Walleij

Subject: Re: [PATCH] pinctrl: realtek: Fix logical error when finding descriptor

On Tue, Nov 21, 2023 at 10:11 AM Tzuyi Chang <[email protected]> wrote:

> The pin descriptor should be returned if the name has been found in the
> descriptor table. Remove the negation in the if statement for accurate
> retrieval.
>
> Fixes: e99ce78030db ("pinctrl: realtek: Add common pinctrl driver for Realtek DHC RTD SoCs")
> Signed-off-by: Tzuyi Chang <[email protected]>

Patch applied for fixes!

Yours,
Linus Walleij