2021-02-08 14:55:27

by Geert Uytterhoeven

Subject: [PATCH] gpio: GPIO_MXS should not default to y, unconditionally

Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
To fix this, restrict the automatic enabling of GPIO_MXS to ARCH_MXS,
and ask the user in case of compile-testing.

Fixes: 6876ca311bfca5d7 ("gpio: mxs: add COMPILE_TEST support for GPIO_MXS")
Signed-off-by: Geert Uytterhoeven <[email protected]>
---
drivers/gpio/Kconfig | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 5fdf526fe973da38..412728ff2ab45c0d 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -442,8 +442,9 @@ config GPIO_MXC
select GENERIC_IRQ_CHIP

config GPIO_MXS
- def_bool y
+ bool "Freescale MXS GPIO support" if COMPILE_TEST
depends on ARCH_MXS || COMPILE_TEST
+ default y if ARCH_MXS
select GPIO_GENERIC
select GENERIC_IRQ_CHIP

--
2.25.1

2021-02-10 13:29:40

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: GPIO_MXS should not default to y, unconditionally

On Mon, Feb 8, 2021 at 3:51 PM Geert Uytterhoeven
<[email protected]> wrote:
>
> Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
> To fix this, restrict the automatic enabling of GPIO_MXS to ARCH_MXS,
> and ask the user in case of compile-testing.
>
> Fixes: 6876ca311bfca5d7 ("gpio: mxs: add COMPILE_TEST support for GPIO_MXS")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> drivers/gpio/Kconfig | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 5fdf526fe973da38..412728ff2ab45c0d 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -442,8 +442,9 @@ config GPIO_MXC
> select GENERIC_IRQ_CHIP
>
> config GPIO_MXS
> - def_bool y
> + bool "Freescale MXS GPIO support" if COMPILE_TEST
> depends on ARCH_MXS || COMPILE_TEST
> + default y if ARCH_MXS
> select GPIO_GENERIC
> select GENERIC_IRQ_CHIP
>
> --
> 2.25.1
>

Applied, thanks!

Bartosz

2021-02-12 13:12:37

by Linus Walleij

Subject: Re: [PATCH] gpio: GPIO_MXS should not default to y, unconditionally

On Mon, Feb 8, 2021 at 3:51 PM Geert Uytterhoeven
<[email protected]> wrote:

> Merely enabling CONFIG_COMPILE_TEST should not enable additional code.
> To fix this, restrict the automatic enabling of GPIO_MXS to ARCH_MXS,
> and ask the user in case of compile-testing.
>
> Fixes: 6876ca311bfca5d7 ("gpio: mxs: add COMPILE_TEST support for GPIO_MXS")
> Signed-off-by: Geert Uytterhoeven <[email protected]>

Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij