2024-02-20 17:54:55

by Bartosz Golaszewski

Subject: [PATCH] gpio: sim: delimit the fwnode name with a ":" when generating labels

From: Bartosz Golaszewski <[email protected]>

Typically, whenever a human-readable name is created for objects using
a software node, its name is delimited with ":" as dashes are often used
in other parts of the name. Make gpio-sim use the same pattern. This
results in better looking default names:

gpio-sim.0:node0
gpio-sim.0:node1
gpio-sim.1:node0

Signed-off-by: Bartosz Golaszewski <[email protected]>
---
drivers/gpio/gpio-sim.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
index c4106e37e6db..1f3dd95dd6da 100644
--- a/drivers/gpio/gpio-sim.c
+++ b/drivers/gpio/gpio-sim.c
@@ -420,7 +420,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)

ret = fwnode_property_read_string(swnode, "gpio-sim,label", &label);
if (ret) {
- label = devm_kasprintf(dev, GFP_KERNEL, "%s-%pfwP",
+ label = devm_kasprintf(dev, GFP_KERNEL, "%s:%pfwP",
dev_name(dev), swnode);
if (!label)
return -ENOMEM;
@@ -833,7 +833,7 @@ static int gpio_sim_add_hogs(struct gpio_sim_device *dev)
GFP_KERNEL);
else
hog->chip_label = kasprintf(GFP_KERNEL,
- "gpio-sim.%u-%pfwP",
+ "gpio-sim.%u:%pfwP",
dev->id,
bank->swnode);
if (!hog->chip_label) {
--
2.40.1

2024-02-21 22:50:39

by Linus Walleij

Subject: Re: [PATCH] gpio: sim: delimit the fwnode name with a ":" when generating labels

On Tue, Feb 20, 2024 at 2:54 PM Bartosz Golaszewski <[email protected]> wrote:

> From: Bartosz Golaszewski <[email protected]>
>
> Typically, whenever a human-readable name is created for objects using
> a software node, its name is delimited with ":" as dashes are often used
> in other parts of the name. Make gpio-sim use the same pattern. This
> results in better looking default names:
>
> gpio-sim.0:node0
> gpio-sim.0:node1
> gpio-sim.1:node0
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>

LGTM
Acked-by: Linus Walleij <[email protected]>

I guess it could affect some tests?

Yours,
Linus Walleij

2024-02-23 08:58:07

by Bartosz Golaszewski

Subject: Re: [PATCH] gpio: sim: delimit the fwnode name with a ":" when generating labels

On Tue, Feb 20, 2024 at 2:54 PM Bartosz Golaszewski <[email protected]> wrote:
>
> From: Bartosz Golaszewski <[email protected]>
>
> Typically, whenever a human-readable name is created for objects using
> a software node, its name is delimited with ":" as dashes are often used
> in other parts of the name. Make gpio-sim use the same pattern. This
> results in better looking default names:
>
> gpio-sim.0:node0
> gpio-sim.0:node1
> gpio-sim.1:node0
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> ---
> drivers/gpio/gpio-sim.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
> index c4106e37e6db..1f3dd95dd6da 100644
> --- a/drivers/gpio/gpio-sim.c
> +++ b/drivers/gpio/gpio-sim.c
> @@ -420,7 +420,7 @@ static int gpio_sim_add_bank(struct fwnode_handle *swnode, struct device *dev)
>
> ret = fwnode_property_read_string(swnode, "gpio-sim,label", &label);
> if (ret) {
> - label = devm_kasprintf(dev, GFP_KERNEL, "%s-%pfwP",
> + label = devm_kasprintf(dev, GFP_KERNEL, "%s:%pfwP",
> dev_name(dev), swnode);
> if (!label)
> return -ENOMEM;
> @@ -833,7 +833,7 @@ static int gpio_sim_add_hogs(struct gpio_sim_device *dev)
> GFP_KERNEL);
> else
> hog->chip_label = kasprintf(GFP_KERNEL,
> - "gpio-sim.%u-%pfwP",
> + "gpio-sim.%u:%pfwP",
> dev->id,
> bank->swnode);
> if (!hog->chip_label) {
> --
> 2.40.1
>

Patch applied.

Bart