2023-07-21 10:17:45

by Sricharan Ramabadhran

Subject: [PATCH] pinctrl: qcom: Remove the unused _groups variable build warning

When building with clang toolchain and arm64-randconfig-r015-20230712
kernel test robot reports the below warning.

drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups' [-Wunused-const-variable]
static const char * const _groups[] = {
^
1 warning generated.

static const char * const _groups[] = {
"gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7",
"gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
"gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21",
"gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28",
"gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
"gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
"gpio43", "gpio44", "gpio45", "gpio46",
};

Fixing it by removing the variable.

Reported-by: kernel test robot <[email protected]>
Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
Fixes: 725d1c891658 ("pinctrl: qcom: Add IPQ5018 pinctrl driver")
Signed-off-by: Sricharan Ramabadhran <[email protected]>
---
drivers/pinctrl/qcom/pinctrl-ipq5018.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/drivers/pinctrl/qcom/pinctrl-ipq5018.c b/drivers/pinctrl/qcom/pinctrl-ipq5018.c
index ed58f75..e2951f8 100644
--- a/drivers/pinctrl/qcom/pinctrl-ipq5018.c
+++ b/drivers/pinctrl/qcom/pinctrl-ipq5018.c
@@ -241,16 +241,6 @@ static const char * const atest_char_groups[] = {
"gpio0", "gpio1", "gpio2", "gpio3", "gpio37",
};

-static const char * const _groups[] = {
- "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7",
- "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
- "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21",
- "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28",
- "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
- "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
- "gpio43", "gpio44", "gpio45", "gpio46",
-};
-
static const char * const wci_txd_groups[] = {
"gpio0", "gpio1", "gpio2", "gpio3",
"gpio42", "gpio43", "gpio44", "gpio45",
--
2.7.4

2023-07-21 21:14:18

by Nick Desaulniers

Subject: Re: [PATCH] pinctrl: qcom: Remove the unused _groups variable build warning

On Fri, Jul 21, 2023 at 3:13 AM Sricharan Ramabadhran
<[email protected]> wrote:
>
> When building with clang toolchain and arm64-randconfig-r015-20230712
> kernel test robot reports the below warning.
>
> drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups' [-Wunused-const-variable]
> static const char * const _groups[] = {
> ^
> 1 warning generated.
>
> static const char * const _groups[] = {
> "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7",
> "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
> "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21",
> "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28",
> "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
> "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
> "gpio43", "gpio44", "gpio45", "gpio46",
> };
>
> Fixing it by removing the variable.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Fixes: 725d1c891658 ("pinctrl: qcom: Add IPQ5018 pinctrl driver")
> Signed-off-by: Sricharan Ramabadhran <[email protected]>

Thanks for the patch!
Reviewed-by: Nick Desaulniers <[email protected]>

> ---
> drivers/pinctrl/qcom/pinctrl-ipq5018.c | 10 ----------
> 1 file changed, 10 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-ipq5018.c b/drivers/pinctrl/qcom/pinctrl-ipq5018.c
> index ed58f75..e2951f8 100644
> --- a/drivers/pinctrl/qcom/pinctrl-ipq5018.c
> +++ b/drivers/pinctrl/qcom/pinctrl-ipq5018.c
> @@ -241,16 +241,6 @@ static const char * const atest_char_groups[] = {
> "gpio0", "gpio1", "gpio2", "gpio3", "gpio37",
> };
>
> -static const char * const _groups[] = {
> - "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7",
> - "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
> - "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21",
> - "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28",
> - "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
> - "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
> - "gpio43", "gpio44", "gpio45", "gpio46",
> -};
> -
> static const char * const wci_txd_groups[] = {
> "gpio0", "gpio1", "gpio2", "gpio3",
> "gpio42", "gpio43", "gpio44", "gpio45",
> --
> 2.7.4
>
>


--
Thanks,
~Nick Desaulniers

2023-07-24 19:26:40

by Krzysztof Kozlowski

Subject: Re: [PATCH] pinctrl: qcom: Remove the unused _groups variable build warning

On 21/07/2023 12:12, Sricharan Ramabadhran wrote:
> When building with clang toolchain and arm64-randconfig-r015-20230712
> kernel test robot reports the below warning.
>
> drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups' [-Wunused-const-variable]
> static const char * const _groups[] = {
> ^
> 1 warning generated.
>
> static const char * const _groups[] = {
> "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7",
> "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
> "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21",
> "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28",
> "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
> "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
> "gpio43", "gpio44", "gpio45", "gpio46",
> };
>
> Fixing it by removing the variable.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Fixes: 725d1c891658 ("pinctrl: qcom: Add IPQ5018 pinctrl driver")
> Signed-off-by: Sricharan Ramabadhran <[email protected]>

This seems to be a duplicate of gpio_groups, so:

Reviewed-by: Krzysztof Kozlowski <[email protected]>

Best regards,
Krzysztof

2023-08-07 10:46:25

by Linus Walleij

Subject: Re: [PATCH] pinctrl: qcom: Remove the unused _groups variable build warning

On Fri, Jul 21, 2023 at 12:13 PM Sricharan Ramabadhran
<[email protected]> wrote:

> When building with clang toolchain and arm64-randconfig-r015-20230712
> kernel test robot reports the below warning.
>
> drivers/pinctrl/qcom/pinctrl-ipq5018.c:244:27: warning: unused variable '_groups' [-Wunused-const-variable]
> static const char * const _groups[] = {
> ^
> 1 warning generated.
>
> static const char * const _groups[] = {
> "gpio0", "gpio1", "gpio2", "gpio3", "gpio4", "gpio5", "gpio6", "gpio7",
> "gpio8", "gpio9", "gpio10", "gpio11", "gpio12", "gpio13", "gpio14",
> "gpio15", "gpio16", "gpio17", "gpio18", "gpio19", "gpio20", "gpio21",
> "gpio22", "gpio23", "gpio24", "gpio25", "gpio26", "gpio27", "gpio28",
> "gpio29", "gpio30", "gpio31", "gpio32", "gpio33", "gpio34", "gpio35",
> "gpio36", "gpio37", "gpio38", "gpio39", "gpio40", "gpio41", "gpio42",
> "gpio43", "gpio44", "gpio45", "gpio46",
> };
>
> Fixing it by removing the variable.
>
> Reported-by: kernel test robot <[email protected]>
> Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/
> Fixes: 725d1c891658 ("pinctrl: qcom: Add IPQ5018 pinctrl driver")
> Signed-off-by: Sricharan Ramabadhran <[email protected]>

Patch applied, thanks for fixing this!

Yours,
Linus Walleij