2022-05-21 15:41:03

by Ben Chuang

Subject: [RESEND, PATCH] mmc: sdhci-pci-gli: Fix GL9763E runtime PM when the system resumes from suspend

When the system resumes from suspend (S3 or S4), the power mode is
MMC_POWER_OFF. In this status, gl9763e_runtime_resume() should not enable
PLL. Add a condition to this function to enable PLL only when the power
mode is MMC_POWER_ON.

Fixes: d607667bb8fa (mmc: sdhci-pci-gli: Add runtime PM for GL9763E)
Signed-off-by: Ben Chuang <[email protected]>
---
Hi,

Sorry, resend this patch because typo two email addresses.
Sorry for Adrian and Kane.

Best regards,
Ben
---
drivers/mmc/host/sdhci-pci-gli.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
index d09728c37d03..d81e5dc90e15 100644
--- a/drivers/mmc/host/sdhci-pci-gli.c
+++ b/drivers/mmc/host/sdhci-pci-gli.c
@@ -972,6 +972,9 @@ static int gl9763e_runtime_resume(struct sdhci_pci_chip *chip)
struct sdhci_host *host = slot->host;
u16 clock;

+ if (host->mmc->ios.power_mode != MMC_POWER_ON)
+ return 0;
+
clock = sdhci_readw(host, SDHCI_CLOCK_CONTROL);

clock |= SDHCI_CLOCK_PLL_EN;
--
2.36.0

2022-06-01 20:39:43

by Ulf Hansson

Subject: Re: [RESEND, PATCH] mmc: sdhci-pci-gli: Fix GL9763E runtime PM when the system resumes from suspend

On Fri, 20 May 2022 at 13:43, Ben Chuang <[email protected]> wrote:
>
> When the system resumes from suspend (S3 or S4), the power mode is
> MMC_POWER_OFF. In this status, gl9763e_runtime_resume() should not enable
> PLL. Add a condition to this function to enable PLL only when the power
> mode is MMC_POWER_ON.
>
> Fixes: d607667bb8fa (mmc: sdhci-pci-gli: Add runtime PM for GL9763E)
> Signed-off-by: Ben Chuang <[email protected]>

Sorry for the delay, I have been out traveling. Unfortunately this
didn't make it for v5.18, although I have queued it up for v5.19 and
added a stable tag.

Thanks and kind regards
Uffe


> ---
> Hi,
>
> Sorry, resend this patch because typo two email addresses.
> Sorry for Adrian and Kane.
>
> Best regards,
> Ben
> ---
> drivers/mmc/host/sdhci-pci-gli.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> index d09728c37d03..d81e5dc90e15 100644
> --- a/drivers/mmc/host/sdhci-pci-gli.c
> +++ b/drivers/mmc/host/sdhci-pci-gli.c
> @@ -972,6 +972,9 @@ static int gl9763e_runtime_resume(struct sdhci_pci_chip *chip)
> struct sdhci_host *host = slot->host;
> u16 clock;
>
> + if (host->mmc->ios.power_mode != MMC_POWER_ON)
> + return 0;
> +
> clock = sdhci_readw(host, SDHCI_CLOCK_CONTROL);
>
> clock |= SDHCI_CLOCK_PLL_EN;
> --
> 2.36.0
>

2022-06-03 00:56:41

by Ben Chuang

Subject: Re: [RESEND, PATCH] mmc: sdhci-pci-gli: Fix GL9763E runtime PM when the system resumes from suspend

On Tue, May 31, 2022 at 9:39 PM Ulf Hansson <[email protected]> wrote:
>
> On Fri, 20 May 2022 at 13:43, Ben Chuang <[email protected]> wrote:
> >
> > When the system resumes from suspend (S3 or S4), the power mode is
> > MMC_POWER_OFF. In this status, gl9763e_runtime_resume() should not enable
> > PLL. Add a condition to this function to enable PLL only when the power
> > mode is MMC_POWER_ON.
> >
> > Fixes: d607667bb8fa (mmc: sdhci-pci-gli: Add runtime PM for GL9763E)
> > Signed-off-by: Ben Chuang <[email protected]>
>
> Sorry for the delay, I have been out traveling. Unfortunately this
> didn't make it for v5.18, although I have queued it up for v5.19 and
> added a stable tag.
>
> Thanks and kind regards
> Uffe
>

It's ok. Thank you for the explanation.

Best regards,
Ben

>
> > ---
> > Hi,
> >
> > Sorry, resend this patch because typo two email addresses.
> > Sorry for Adrian and Kane.
> >
> > Best regards,
> > Ben
> > ---
> > drivers/mmc/host/sdhci-pci-gli.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c
> > index d09728c37d03..d81e5dc90e15 100644
> > --- a/drivers/mmc/host/sdhci-pci-gli.c
> > +++ b/drivers/mmc/host/sdhci-pci-gli.c
> > @@ -972,6 +972,9 @@ static int gl9763e_runtime_resume(struct sdhci_pci_chip *chip)
> > struct sdhci_host *host = slot->host;
> > u16 clock;
> >
> > + if (host->mmc->ios.power_mode != MMC_POWER_ON)
> > + return 0;
> > +
> > clock = sdhci_readw(host, SDHCI_CLOCK_CONTROL);
> >
> > clock |= SDHCI_CLOCK_PLL_EN;
> > --
> > 2.36.0
> >