2022-04-22 12:11:16

by KP Singh

[permalink] [raw]
Subject: Re: [PATCH bpf-next v2 5/6] bpf, arm64: bpf trampoline for arm64

On Wed, Apr 20, 2022 at 9:44 AM Xu Kuohai <[email protected]> wrote:
>
> On 4/16/2022 9:57 AM, Xu Kuohai wrote:
> > On 4/16/2022 1:12 AM, Andrii Nakryiko wrote:
> >> On Thu, Apr 14, 2022 at 9:10 AM Xu Kuohai <[email protected]> wrote:
> >>>
> >>> Add bpf trampoline support for arm64. Most of the logic is the same as
> >>> x86.
> >>>
> >>> fentry before bpf trampoline hooked:
> >>> mov x9, x30
> >>> nop
> >>>
> >>> fentry after bpf trampoline hooked:
> >>> mov x9, x30
> >>> bl <bpf_trampoline>
> >>>
> >>> Tested on qemu, result:
> >>> #55 fentry_fexit:OK
> >>> #56 fentry_test:OK
> >>> #58 fexit_sleep:OK
> >>> #59 fexit_stress:OK
> >>> #60 fexit_test:OK
> >>> #67 get_func_args_test:OK
> >>> #68 get_func_ip_test:OK
> >>> #101 modify_return:OK
> >>>
> >>> Signed-off-by: Xu Kuohai <[email protected]>
> >>> Acked-by: Song Liu <[email protected]>
> >>> ---
> >>
> >> Can you please also take a look at [0], which is an ongoing work to
> >> add support for BPF cookie to BPF trampoline-based BPF programs. It's
> >> very close to being done, so it would be good if you can implement
> >> that at the same time.
> >
> > OK, I'll take a look and try to implemnt it.
>
> already implemented, but there are some conflicts between these two
> series, will send v3 after trampoline cookie are merged.

Awesome work, Thanks for doing this!