2024-05-09 14:35:33

by Doug Anderson

[permalink] [raw]
Subject: Re: [PATCH v1 2/2] HID: i2c-hid: elan: Add ili2900 timing

Hi,

On Wed, May 8, 2024 at 11:43 PM Zhaoxiong Lv
<[email protected]> wrote:
>
> From: lvzhaoxiong <[email protected]>
>
> ILI2900 requires reset to pull down time greater than 10ms,
> so the configuration post_power_delay_ms is 10, and the chipset
> initial time is required to be greater than 100ms,
> so the post_gpio_reset_on_delay_ms is set to 100.
>
> Signed-off-by: lvzhaoxiong <[email protected]>
> ---
> drivers/hid/i2c-hid/i2c-hid-of-elan.c | 8 ++++++++
> 1 file changed, 8 insertions(+)

You silently ignored pretty much all of the feedback from the previous
version [1], so I'm not planning to review this version.

[1] https://lore.kernel.org/r/CAD=FV=X5tk0tCcDa+vLnu0aoas1TDWuqvkMzM-278dOCX8K1gw@mail.gmail.com