Add support for winbond W25Q512NW-IM chip.
Signed-off-by: Shaik Sajida Bhanu <[email protected]>
---
Changes since V1:
Added space before name of the flash part as suggested by Doug.
---
drivers/mtd/spi-nor/winbond.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
index 96573f6..44f19f2 100644
--- a/drivers/mtd/spi-nor/winbond.c
+++ b/drivers/mtd/spi-nor/winbond.c
@@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
{ "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
+ { "w25q512nw", INFO(0xef8020, 0, 64 * 1024, 1024,
+ SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
+ SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
{ "w25q512jvq", INFO(0xef4020, 0, 64 * 1024, 1024,
SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
};
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Hi,
On Wed, Dec 1, 2021 at 10:38 PM Shaik Sajida Bhanu
<[email protected]> wrote:
>
> Add support for winbond W25Q512NW-IM chip.
>
> Signed-off-by: Shaik Sajida Bhanu <[email protected]>
> ---
> Changes since V1:
> Added space before name of the flash part as suggested by Doug.
When someone comments on V1, it's nice to CC them on V2. ;-)
> ---
> drivers/mtd/spi-nor/winbond.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index 96573f6..44f19f2 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ | SPI_NOR_DUAL_READ) },
> + { "w25q512nw", INFO(0xef8020, 0, 64 * 1024, 1024,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
I had a quick look. Though I'm no expert on this driver, I believe
that the name should be "w25q512nwm", not "w25q512nw" (you need an "m"
at the end). Evidence:
The Winbond doc [1] shows:
W25Q512NW-IM is 0xef8020
W25Q512NW-IQ/IN is 0xef6020
Comparing to a different datasheet [2], I see that:
W25Q256JW-IM is 0xef8019
W25Q256JW is 0xef6019
Since "W25Q256JW-IM" is in code as "w25q256jwm" it implies to me that
for the "-IM" suffix you just add a "m" to the end of the name.
[1] https://www.winbond.com/resource-files/W25Q512NW%20RevB%2007192021.pdf
[2] https://www.winbond.com/resource-files/W25Q256JW%20SPI%20RevJ%2003102021%20Plus.pdf
After changing the name, feel free to add my Reviewed-by (and please
CC me on v3).
-Doug
Hi ,
Thanks for the review.
Sure, Will make the change.
Thanks,
Sajida
-----Original Message-----
From: Doug Anderson <[email protected]>
Sent: Monday, December 13, 2021 9:22 PM
To: Sajida Bhanu (Temp) (QUIC) <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Ram Prakash Gupta (QUIC) <[email protected]>; Pradeep Pragallapati (QUIC) <[email protected]>; [email protected]
Subject: Re: [PATCH V2] mtd: spi-nor: winbond: Add support for winbond chip
WARNING: This email originated from outside of Qualcomm. Please be wary of any links or attachments, and do not enable macros.
Hi,
On Wed, Dec 1, 2021 at 10:38 PM Shaik Sajida Bhanu <[email protected]> wrote:
>
> Add support for winbond W25Q512NW-IM chip.
>
> Signed-off-by: Shaik Sajida Bhanu <[email protected]>
> ---
> Changes since V1:
> Added space before name of the flash part as suggested by Doug.
When someone comments on V1, it's nice to CC them on V2. ;-)
> ---
> drivers/mtd/spi-nor/winbond.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c
> b/drivers/mtd/spi-nor/winbond.c index 96573f6..44f19f2 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ |
> SPI_NOR_DUAL_READ) },
> + { "w25q512nw", INFO(0xef8020, 0, 64 * 1024, 1024,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
I had a quick look. Though I'm no expert on this driver, I believe that the name should be "w25q512nwm", not "w25q512nw" (you need an "m"
at the end). Evidence:
The Winbond doc [1] shows:
W25Q512NW-IM is 0xef8020
W25Q512NW-IQ/IN is 0xef6020
Comparing to a different datasheet [2], I see that:
W25Q256JW-IM is 0xef8019
W25Q256JW is 0xef6019
Since "W25Q256JW-IM" is in code as "w25q256jwm" it implies to me that for the "-IM" suffix you just add a "m" to the end of the name.
[1] https://www.winbond.com/resource-files/W25Q512NW%20RevB%2007192021.pdf
[2] https://www.winbond.com/resource-files/W25Q256JW%20SPI%20RevJ%2003102021%20Plus.pdf
After changing the name, feel free to add my Reviewed-by (and please CC me on v3).
-Doug
Hi ,
Thanks for the review.
Sure, Will make the change.
Thanks,
Sajida
-----Original Message-----
From: Doug Anderson <[email protected]>
Sent: Monday, December 13, 2021 9:22 PM
To: Sajida Bhanu (Temp) (QUIC) <[email protected]>
Cc: [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; [email protected]; Ram Prakash Gupta (QUIC) <[email protected]>; Pradeep Pragallapati (QUIC) <[email protected]>; [email protected]
Subject: Re: [PATCH V2] mtd: spi-nor: winbond: Add support for winbond chip
Hi,
On Wed, Dec 1, 2021 at 10:38 PM Shaik Sajida Bhanu <[email protected]> wrote:
>
> Add support for winbond W25Q512NW-IM chip.
>
> Signed-off-by: Shaik Sajida Bhanu <[email protected]>
> ---
> Changes since V1:
> Added space before name of the flash part as suggested by Doug.
When someone comments on V1, it's nice to CC them on V2. ;-)
> ---
> drivers/mtd/spi-nor/winbond.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c
> b/drivers/mtd/spi-nor/winbond.c index 96573f6..44f19f2 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -100,6 +100,9 @@ static const struct flash_info winbond_parts[] = {
> SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ) },
> { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024,
> SECT_4K | SPI_NOR_QUAD_READ |
> SPI_NOR_DUAL_READ) },
> + { "w25q512nw", INFO(0xef8020, 0, 64 * 1024, 1024,
> + SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ |
> + SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB) },
I had a quick look. Though I'm no expert on this driver, I believe that the name should be "w25q512nwm", not "w25q512nw" (you need an "m"
at the end). Evidence:
The Winbond doc [1] shows:
W25Q512NW-IM is 0xef8020
W25Q512NW-IQ/IN is 0xef6020
Comparing to a different datasheet [2], I see that:
W25Q256JW-IM is 0xef8019
W25Q256JW is 0xef6019
Since "W25Q256JW-IM" is in code as "w25q256jwm" it implies to me that for the "-IM" suffix you just add a "m" to the end of the name.
[1] https://www.winbond.com/resource-files/W25Q512NW%20RevB%2007192021.pdf
[2] https://www.winbond.com/resource-files/W25Q256JW%20SPI%20RevJ%2003102021%20Plus.pdf
After changing the name, feel free to add my Reviewed-by (and please CC me on v3).
-Doug