Hi,
On Mon, May 8, 2023 at 7:52 PM Cong Yang
<[email protected]> wrote:
>
> There is a problem of screen shake on the old panel. So increase the
> panel GOP component pull-down circuit size in hardware, and update the
> initialization code at the same time. The new initialization code mainly
> modifles the following.
>
> a)adjusted for GOP timing. When Display sleep in, raise all GOP signals
> to VGHO and then drop to GND.
> b)Increased the Vertical back Porch and Vertical pulse width, so need to
> update vsync_end and vtotal and CLK in drm_display_mode.
>
> Signed-off-by: Cong Yang <[email protected]>
> ---
> v2: Modify commit message
>
> .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 397 +++++++++++-------
> 1 file changed, 235 insertions(+), 162 deletions(-)
Every time I see the opaque changes to the pile of "DCS_CMD" arrays I
feel obliged to grumble a bit, but as I've said before I guess it's
OK-ish...
Thus, this patch seems fine to me:
Reviewed-by: Douglas Anderson <[email protected]>
Just to make sure there are no objections, I'll give this ~1 week and
then I'll land it to drm-misc-next.
-Doug
Hi,
On Tue, May 9, 2023 at 8:42 AM Doug Anderson <[email protected]> wrote:
>
> Hi,
>
> On Mon, May 8, 2023 at 7:52 PM Cong Yang
> <[email protected]> wrote:
> >
> > There is a problem of screen shake on the old panel. So increase the
> > panel GOP component pull-down circuit size in hardware, and update the
> > initialization code at the same time. The new initialization code mainly
> > modifles the following.
> >
> > a)adjusted for GOP timing. When Display sleep in, raise all GOP signals
> > to VGHO and then drop to GND.
> > b)Increased the Vertical back Porch and Vertical pulse width, so need to
> > update vsync_end and vtotal and CLK in drm_display_mode.
> >
> > Signed-off-by: Cong Yang <[email protected]>
> > ---
> > v2: Modify commit message
> >
> > .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 397 +++++++++++-------
> > 1 file changed, 235 insertions(+), 162 deletions(-)
>
> Every time I see the opaque changes to the pile of "DCS_CMD" arrays I
> feel obliged to grumble a bit, but as I've said before I guess it's
> OK-ish...
>
> Thus, this patch seems fine to me:
>
> Reviewed-by: Douglas Anderson <[email protected]>
>
> Just to make sure there are no objections, I'll give this ~1 week and
> then I'll land it to drm-misc-next.
Pushed to drm-misc-next:
519ce291168a drm/panel: Modify innolux hj110iz panel initial code