2022-10-01 02:32:55

by Zhijian Li (Fujitsu)

Subject: [PATCH for-next] RDMA: return -EOPNOSUPP for ODP unsupported device

ib_reg_mr(3) which is used to register a MR with specific access flags
for specific HCA will set errno when something go wrong.
So, here we should return the specific -EOPNOTSUPP when the being
requested ODP access flag is unspported by the HCA(such as RXE).

Signed-off-by: Li Zhijian <[email protected]>
---
include/rdma/ib_verbs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
index 975d6e9efbcb..a1f4d53a4bb6 100644
--- a/include/rdma/ib_verbs.h
+++ b/include/rdma/ib_verbs.h
@@ -4334,7 +4334,7 @@ static inline int ib_check_mr_access(struct ib_device *ib_dev,

if (flags & IB_ACCESS_ON_DEMAND &&
!(ib_dev->attrs.kernel_cap_flags & IBK_ON_DEMAND_PAGING))
- return -EINVAL;
+ return -EOPNOTSUPP;
return 0;
}

--
2.31.1

2022-10-01 11:23:01

by Zhu Yanjun

Subject: Re: [PATCH for-next] RDMA: return -EOPNOSUPP for ODP unsupported device

On Sat, Oct 1, 2022 at 10:00 AM Li Zhijian <[email protected]> wrote:
>
> ib_reg_mr(3) which is used to register a MR with specific access flags
> for specific HCA will set errno when something go wrong.
> So, here we should return the specific -EOPNOTSUPP when the being
> requested ODP access flag is unspported by the HCA(such as RXE).
>
> Signed-off-by: Li Zhijian <[email protected]>

Reviewed-by: Zhu Yanjun <[email protected]>

Thanks.
Zhu Yanjun
> ---
> include/rdma/ib_verbs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h
> index 975d6e9efbcb..a1f4d53a4bb6 100644
> --- a/include/rdma/ib_verbs.h
> +++ b/include/rdma/ib_verbs.h
> @@ -4334,7 +4334,7 @@ static inline int ib_check_mr_access(struct ib_device *ib_dev,
>
> if (flags & IB_ACCESS_ON_DEMAND &&
> !(ib_dev->attrs.kernel_cap_flags & IBK_ON_DEMAND_PAGING))
> - return -EINVAL;
> + return -EOPNOTSUPP;
> return 0;
> }
>
> --
> 2.31.1
>

2022-10-19 07:16:53

by Leon Romanovsky

Subject: Re: [PATCH for-next] RDMA: return -EOPNOSUPP for ODP unsupported device

On Sat, 1 Oct 2022 10:00:45 +0800, Li Zhijian wrote:
> ib_reg_mr(3) which is used to register a MR with specific access flags
> for specific HCA will set errno when something go wrong.
> So, here we should return the specific -EOPNOTSUPP when the being
> requested ODP access flag is unspported by the HCA(such as RXE).
>
>

Applied, thanks!

[1/1] RDMA: return -EOPNOSUPP for ODP unsupported device
https://git.kernel.org/rdma/rdma/c/0154331c318907

Best regards,
--
Leon Romanovsky <[email protected]>