2016-10-19 06:28:03

by Valentin Rothberg

[permalink] [raw]
Subject: drm/i915: undefined STOP_MACHINE

Dear Chris,

your commit 9f267eb8d2ea ("drm/i915: Stop the machine whilst capturing
the GPU crash dump") has popped up in today's linux-next and adds a
select from DRM_I915 on STOP_MACHINE, which is not defined anywhere in
Kconfig.

STOP_MACHINE has been removed a while ago (see
https://lkml.org/lkml/2015/11/19/133). I assume that HOTPLUG_CPU
could be used?

I detected the issue with scripts/checkkconfigsymbols.py by diffing
yesterday's and today's linux-next.

Best regards,
Valentin


2016-10-19 14:44:37

by Chris Wilson

[permalink] [raw]
Subject: Re: drm/i915: undefined STOP_MACHINE

On Wed, Oct 19, 2016 at 08:27:23AM +0200, Valentin Rothberg wrote:
> Dear Chris,
>
> your commit 9f267eb8d2ea ("drm/i915: Stop the machine whilst capturing
> the GPU crash dump") has popped up in today's linux-next and adds a
> select from DRM_I915 on STOP_MACHINE, which is not defined anywhere in
> Kconfig.
>
> STOP_MACHINE has been removed a while ago (see
> https://lkml.org/lkml/2015/11/19/133). I assume that HOTPLUG_CPU
> could be used?

No. We don't need the select anymore as the core machinery now just
works without having to force compilation of the correct code.
-Chris

--
Chris Wilson, Intel Open Source Technology Centre

2016-10-19 19:07:22

by Chris Wilson

[permalink] [raw]
Subject: Re: drm/i915: undefined STOP_MACHINE

On Wed, Oct 19, 2016 at 08:26:35AM +0100, Chris Wilson wrote:
> On Wed, Oct 19, 2016 at 08:27:23AM +0200, Valentin Rothberg wrote:
> > Dear Chris,
> >
> > your commit 9f267eb8d2ea ("drm/i915: Stop the machine whilst capturing
> > the GPU crash dump") has popped up in today's linux-next and adds a
> > select from DRM_I915 on STOP_MACHINE, which is not defined anywhere in
> > Kconfig.
> >
> > STOP_MACHINE has been removed a while ago (see
> > https://lkml.org/lkml/2015/11/19/133). I assume that HOTPLUG_CPU
> > could be used?
>
> No. We don't need the select anymore as the core machinery now just
> works without having to force compilation of the correct code.

I completely forgot that we already had serialised with the STOP_MACHINE
removal and had accidentally reintroduce the select in commit
9f267eb8d2ea ("drm/i915: Stop the machine whilst capturing the GPU
crash dump")

Thanks,
-Chris

--
Chris Wilson, Intel Open Source Technology Centre