2015-05-11 07:43:26

by Valentin Rothberg

[permalink] [raw]
Subject: locking/pvqspinlock, x86: undefined CONFIG_QUEUED_SPINLOCKS

Hi Peter,

your commit f233f7f1581e ("locking/pvqspinlock, x86: Implement the
paravirt qspinlock call patching") is in today's linux-next tree
(i.e., next-20150511). The two #ifdef blocks listed below cannot be
compiled at the current state since CONFIG_QUEUED_SPINLOCKS does not
exist:

+#if defined(CONFIG_PARAVIRT_SPINLOCKS) && defined(CONFIG_QUEUED_SPINLOCKS)
[...]
+#if defined(CONFIG_PARAVIRT_SPINLOCKS) && defined(CONFIG_QUEUED_SPINLOCKS)

It seems that it's just a typo, since QUEUED_SPINLOCK (i.e., without
last S) is defined in kernel/Kconfig.locks.

I detected this issue with scripts/checkkconfigsymbols.py by diffing
today's and the previous next tree.

Kind regards,
Valentin