2023-07-24 04:40:23

by Ran Sun

Subject: [PATCH] drm/radeon: Move assignment outside if condition

Fixes the following checkpatch errors:

ERROR: do not use assignment in if condition

Signed-off-by: Ran Sun <[email protected]>
---
drivers/gpu/drm/radeon/radeon_legacy_tv.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_legacy_tv.c
b/drivers/gpu/drm/radeon/radeon_legacy_tv.c
index 12e180b119ac..7883e9ec0bae 100644
--- a/drivers/gpu/drm/radeon/radeon_legacy_tv.c
+++ b/drivers/gpu/drm/radeon/radeon_legacy_tv.c
@@ -724,12 +724,14 @@ void radeon_legacy_tv_mode_set(struct drm_encoder
*encoder,
}

for (i = 0; i < MAX_H_CODE_TIMING_LEN; i++) {
- if ((tv_dac->tv.h_code_timing[i] = hor_timing[i]) == 0)
+ tv_dac->tv.h_code_timing[i] = hor_timing[i];
+ if (tv_dac->tv.h_code_timing[i] == 0)
break;
}

for (i = 0; i < MAX_V_CODE_TIMING_LEN; i++) {
- if ((tv_dac->tv.v_code_timing[i] = vert_timing[i]) == 0)
+ tv_dac->tv.v_code_timing[i] = vert_timing[i];
+ if (tv_dac->tv.v_code_timing[i] == 0)
break;
}

2023-07-24 22:41:18

by Alex Deucher

Subject: Re: [PATCH] drm/radeon: Move assignment outside if condition

Applied. Thanks!

On Sun, Jul 23, 2023 at 11:45 PM <[email protected]> wrote:
>
> Fixes the following checkpatch errors:
>
> ERROR: do not use assignment in if condition
>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> drivers/gpu/drm/radeon/radeon_legacy_tv.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_legacy_tv.c
> b/drivers/gpu/drm/radeon/radeon_legacy_tv.c
> index 12e180b119ac..7883e9ec0bae 100644
> --- a/drivers/gpu/drm/radeon/radeon_legacy_tv.c
> +++ b/drivers/gpu/drm/radeon/radeon_legacy_tv.c
> @@ -724,12 +724,14 @@ void radeon_legacy_tv_mode_set(struct drm_encoder
> *encoder,
> }
>
> for (i = 0; i < MAX_H_CODE_TIMING_LEN; i++) {
> - if ((tv_dac->tv.h_code_timing[i] = hor_timing[i]) == 0)
> + tv_dac->tv.h_code_timing[i] = hor_timing[i];
> + if (tv_dac->tv.h_code_timing[i] == 0)
> break;
> }
>
> for (i = 0; i < MAX_V_CODE_TIMING_LEN; i++) {
> - if ((tv_dac->tv.v_code_timing[i] = vert_timing[i]) == 0)
> + tv_dac->tv.v_code_timing[i] = vert_timing[i];
> + if (tv_dac->tv.v_code_timing[i] == 0)
> break;
> }