2023-03-03 12:03:10

by Muhammad Usama Anjum

Subject: [PATCH] drm/amdgpu: remove dead code

The less than zero comparison of unsigned variable "value" is never
true. Remove dead code.

Fixes: c3ed0e72c872 ("drm/amdgpu: added a sysfs interface for thermal throttling")
Signed-off-by: Muhammad Usama Anjum <[email protected]>
---
drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
index f212cae0353f..0ffe351c1a1d 100644
--- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
+++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
@@ -1738,7 +1738,7 @@ static ssize_t amdgpu_set_apu_thermal_cap(struct device *dev,
if (ret)
return ret;

- if (value < 0 || value > 100) {
+ if (value > 100) {
dev_err(dev, "Invalid argument !\n");
return -EINVAL;
}
--
2.39.2

2023-03-03 22:06:45

by Alex Deucher

Subject: Re: [PATCH] drm/amdgpu: remove dead code

Applied. Thanks!

Alex

On Fri, Mar 3, 2023 at 7:03 AM Muhammad Usama Anjum
<[email protected]> wrote:
>
> The less than zero comparison of unsigned variable "value" is never
> true. Remove dead code.
>
> Fixes: c3ed0e72c872 ("drm/amdgpu: added a sysfs interface for thermal throttling")
> Signed-off-by: Muhammad Usama Anjum <[email protected]>
> ---
> drivers/gpu/drm/amd/pm/amdgpu_pm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> index f212cae0353f..0ffe351c1a1d 100644
> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c
> @@ -1738,7 +1738,7 @@ static ssize_t amdgpu_set_apu_thermal_cap(struct device *dev,
> if (ret)
> return ret;
>
> - if (value < 0 || value > 100) {
> + if (value > 100) {
> dev_err(dev, "Invalid argument !\n");
> return -EINVAL;
> }
> --
> 2.39.2
>