2022-01-26 11:41:07

by Stephen Rothwell

[permalink] [raw]

Subject: linux-next: Fixes tag needs some work in the amdgpu tree

---

Hi all,

In commit

69bba523d97a ("drm/amdgpu: Fix kernel compilation; style")

Fixes tag

Fixes: 1b08dfb889b2c5 ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")

has these problem(s):

- Subject does not match target commit subject
Just use
git log -1 --format='Fixes: %h ("%s")'

Thus:

Fixes: 1b08dfb889b2 ("drm/amdgpu: remove gart.ready flag")

or

Fixes: eadabcc2bc6c ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")

--
Cheers,
Stephen Rothwell

---

Attachments:

(No filename) (499.00 B)
OpenPGP digital signature

2022-01-26 12:40:50

by Luben Tuikov

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the amdgpu tree

---

Not sure what to do with this, because in our tree, I see this:

commit 824c2051039dfc
Author: shaoyunl <[email protected]>
Date:   Thu Jan 20 10:39:41 2022 -0500

    drm/amdgpu: Disable FRU EEPROM access for SRIOV


And this is what I used.

Regards,
Luben


On 2022-01-25 17:40, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> 69bba523d97a ("drm/amdgpu: Fix kernel compilation; style")
>
> Fixes tag
>
> Fixes: 1b08dfb889b2c5 ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
>
> has these problem(s):
>
> - Subject does not match target commit subject
> Just use
> git log -1 --format='Fixes: %h ("%s")'
>
> Thus:
>
> Fixes: 1b08dfb889b2 ("drm/amdgpu: remove gart.ready flag")
>
> or
>
> Fixes: eadabcc2bc6c ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
>

Regards,
--
Luben

2022-01-26 12:57:06

by Alex Deucher

[permalink] [raw]

Subject: Re: linux-next: Fixes tag needs some work in the amdgpu tree

---

On Tue, Jan 25, 2022 at 5:59 PM Luben Tuikov <[email protected]> wrote:
>
> Not sure what to do with this, because in our tree, I see this:
>
> commit 824c2051039dfc
> Author: shaoyunl <[email protected]>
> Date: Thu Jan 20 10:39:41 2022 -0500
>
> drm/amdgpu: Disable FRU EEPROM access for SRIOV
>
>
> And this is what I used.

I typo-ed it when I fixed it up. Properly fixed up now.

Alex

>
> Regards,
> Luben
>
>
> On 2022-01-25 17:40, Stephen Rothwell wrote:
> > Hi all,
> >
> > In commit
> >
> > 69bba523d97a ("drm/amdgpu: Fix kernel compilation; style")
> >
> > Fixes tag
> >
> > Fixes: 1b08dfb889b2c5 ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
> >
> > has these problem(s):
> >
> > - Subject does not match target commit subject
> > Just use
> > git log -1 --format='Fixes: %h ("%s")'
> >
> > Thus:
> >
> > Fixes: 1b08dfb889b2 ("drm/amdgpu: remove gart.ready flag")
> >
> > or
> >
> > Fixes: eadabcc2bc6c ("drm/amdgpu: Disable FRU EEPROM access for SRIOV")
> >
>
> Regards,
> --
> Luben
>