2023-08-02 02:06:32

by Ran Sun

Subject: [PATCH] drm/amd/pm: Clean up errors in hwmgr.h

Fix the following errors reported by checkpatch:

ERROR: open brace '{' following struct go on the same line
ERROR: Use C99 flexible arrays

Signed-off-by: Ran Sun <[email protected]>
---
drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h b/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h
index 612d66aeaab9..81650727a5de 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h
+++ b/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h
@@ -190,8 +190,7 @@ struct phm_vce_clock_voltage_dependency_table {
};


-enum SMU_ASIC_RESET_MODE
-{
+enum SMU_ASIC_RESET_MODE {
SMU_ASIC_RESET_MODE_0,
SMU_ASIC_RESET_MODE_1,
SMU_ASIC_RESET_MODE_2,
@@ -516,7 +515,7 @@ struct phm_vq_budgeting_record {

struct phm_vq_budgeting_table {
uint8_t numEntries;
- struct phm_vq_budgeting_record entries[1];
+ struct phm_vq_budgeting_record entries[0];
};

struct phm_clock_and_voltage_limits {
@@ -607,8 +606,7 @@ struct phm_ppt_v2_information {
uint8_t uc_dcef_dpm_voltage_mode;
};

-struct phm_ppt_v3_information
-{
+struct phm_ppt_v3_information {
uint8_t uc_thermal_controller_type;

uint16_t us_small_power_limit1;
--
2.17.1

2023-08-07 17:24:24

by Alex Deucher

Subject: Re: [PATCH] drm/amd/pm: Clean up errors in hwmgr.h

Applied. Thanks!

On Tue, Aug 1, 2023 at 9:48 PM Ran Sun <[email protected]> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: open brace '{' following struct go on the same line
> ERROR: Use C99 flexible arrays
>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h b/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h
> index 612d66aeaab9..81650727a5de 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h
> +++ b/drivers/gpu/drm/amd/pm/powerplay/inc/hwmgr.h
> @@ -190,8 +190,7 @@ struct phm_vce_clock_voltage_dependency_table {
> };
>
>
> -enum SMU_ASIC_RESET_MODE
> -{
> +enum SMU_ASIC_RESET_MODE {
> SMU_ASIC_RESET_MODE_0,
> SMU_ASIC_RESET_MODE_1,
> SMU_ASIC_RESET_MODE_2,
> @@ -516,7 +515,7 @@ struct phm_vq_budgeting_record {
>
> struct phm_vq_budgeting_table {
> uint8_t numEntries;
> - struct phm_vq_budgeting_record entries[1];
> + struct phm_vq_budgeting_record entries[0];
> };
>
> struct phm_clock_and_voltage_limits {
> @@ -607,8 +606,7 @@ struct phm_ppt_v2_information {
> uint8_t uc_dcef_dpm_voltage_mode;
> };
>
> -struct phm_ppt_v3_information
> -{
> +struct phm_ppt_v3_information {
> uint8_t uc_thermal_controller_type;
>
> uint16_t us_small_power_limit1;
> --
> 2.17.1
>