2022-07-14 16:49:41

by Maira Canal

Subject: [PATCH 03/12] drm/amd/display: Remove unused clk_src variable

Remove the variable clk_src from the function dcn3_get_pix_clk_dividers.

This was pointed by clang with the following warning:

drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:1279:25: warning:
variable 'clk_src' set but not used [-Wunused-but-set-variable]
struct dce110_clk_src *clk_src;
^
1 warning generated.

Signed-off-by: Maíra Canal <[email protected]>
---
drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
index 5cc7cc0b2f2d..d55da1ab1ac2 100644
--- a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
+++ b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
@@ -1276,9 +1276,7 @@ static uint32_t dcn3_get_pix_clk_dividers(
struct pll_settings *pll_settings)
{
unsigned long long actual_pix_clk_100Hz = pix_clk_params ? pix_clk_params->requested_pix_clk_100hz : 0;
- struct dce110_clk_src *clk_src;

- clk_src = TO_DCE110_CLK_SRC(cs);
DC_LOGGER_INIT();

if (pix_clk_params == NULL || pll_settings == NULL
--
2.36.1

2022-07-18 19:16:54

by Alex Deucher

Subject: Re: [PATCH 03/12] drm/amd/display: Remove unused clk_src variable

Applied. Thanks!

Alex

On Thu, Jul 14, 2022 at 12:45 PM Maíra Canal <[email protected]> wrote:
>
> Remove the variable clk_src from the function dcn3_get_pix_clk_dividers.
>
> This was pointed by clang with the following warning:
>
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_clock_source.c:1279:25: warning:
> variable 'clk_src' set but not used [-Wunused-but-set-variable]
> struct dce110_clk_src *clk_src;
> ^
> 1 warning generated.
>
> Signed-off-by: Maíra Canal <[email protected]>
> ---
> drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
> index 5cc7cc0b2f2d..d55da1ab1ac2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_clock_source.c
> @@ -1276,9 +1276,7 @@ static uint32_t dcn3_get_pix_clk_dividers(
> struct pll_settings *pll_settings)
> {
> unsigned long long actual_pix_clk_100Hz = pix_clk_params ? pix_clk_params->requested_pix_clk_100hz : 0;
> - struct dce110_clk_src *clk_src;
>
> - clk_src = TO_DCE110_CLK_SRC(cs);
> DC_LOGGER_INIT();
>
> if (pix_clk_params == NULL || pll_settings == NULL
> --
> 2.36.1
>