2023-11-16 19:15:19

by Alex Deucher

[permalink] [raw]
Subject: Re: [PATCH 19/20] drivers/gpu/drm/display: remove I2C_CLASS_DDC support

On Mon, Nov 13, 2023 at 6:24 AM Heiner Kallweit <[email protected]> wrote:
>
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <[email protected]>

Acked-by: Alex Deucher <[email protected]>

>
> ---
> drivers/gpu/drm/display/drm_dp_helper.c | 1 -
> drivers/gpu/drm/display/drm_dp_mst_topology.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c
> index f3680f4e6..ac901f4b4 100644
> --- a/drivers/gpu/drm/display/drm_dp_helper.c
> +++ b/drivers/gpu/drm/display/drm_dp_helper.c
> @@ -2102,7 +2102,6 @@ int drm_dp_aux_register(struct drm_dp_aux *aux)
> if (!aux->ddc.algo)
> drm_dp_aux_init(aux);
>
> - aux->ddc.class = I2C_CLASS_DDC;
> aux->ddc.owner = THIS_MODULE;
> aux->ddc.dev.parent = aux->dev;
>
> diff --git a/drivers/gpu/drm/display/drm_dp_mst_topology.c b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> index 0e0d0e76d..4376e2c1f 100644
> --- a/drivers/gpu/drm/display/drm_dp_mst_topology.c
> +++ b/drivers/gpu/drm/display/drm_dp_mst_topology.c
> @@ -5803,7 +5803,6 @@ static int drm_dp_mst_register_i2c_bus(struct drm_dp_mst_port *port)
> aux->ddc.algo_data = aux;
> aux->ddc.retries = 3;
>
> - aux->ddc.class = I2C_CLASS_DDC;
> aux->ddc.owner = THIS_MODULE;
> /* FIXME: set the kdev of the port's connector as parent */
> aux->ddc.dev.parent = parent_dev;
>