2023-08-02 07:32:07

by Ran Sun

Subject: [PATCH] drm/amdgpu/jpeg: Clean up errors in vcn_v1_0.c

Fix the following errors reported by checkpatch:

ERROR: space required before the open parenthesis '('
ERROR: space prohibited after that '~' (ctx:WxW)

Signed-off-by: Ran Sun <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
index 16feb491adf5..25ba27151ac0 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
@@ -473,7 +473,7 @@ static void vcn_v1_0_disable_clock_gating(struct amdgpu_device *adev)
if (adev->cg_flags & AMD_CG_SUPPORT_VCN_MGCG)
data |= 1 << UVD_CGC_CTRL__DYN_CLOCK_MODE__SHIFT;
else
- data &= ~ UVD_CGC_CTRL__DYN_CLOCK_MODE_MASK;
+ data &= ~UVD_CGC_CTRL__DYN_CLOCK_MODE_MASK;

data |= 1 << UVD_CGC_CTRL__CLK_GATE_DLY_TIMER__SHIFT;
data |= 4 << UVD_CGC_CTRL__CLK_OFF_DELAY__SHIFT;
@@ -1772,7 +1772,7 @@ static int vcn_v1_0_set_powergating_state(void *handle,
int ret;
struct amdgpu_device *adev = (struct amdgpu_device *)handle;

- if(state == adev->vcn.cur_state)
+ if (state == adev->vcn.cur_state)
return 0;

if (state == AMD_PG_STATE_GATE)
@@ -1780,7 +1780,7 @@ static int vcn_v1_0_set_powergating_state(void *handle,
else
ret = vcn_v1_0_start(adev);

- if(!ret)
+ if (!ret)
adev->vcn.cur_state = state;
return ret;
}
@@ -2065,8 +2065,7 @@ static void vcn_v1_0_set_irq_funcs(struct amdgpu_device *adev)
adev->vcn.inst->irq.funcs = &vcn_v1_0_irq_funcs;
}

-const struct amdgpu_ip_block_version vcn_v1_0_ip_block =
-{
+const struct amdgpu_ip_block_version vcn_v1_0_ip_block = {
.type = AMD_IP_BLOCK_TYPE_VCN,
.major = 1,
.minor = 0,
--
2.17.1

2023-08-07 18:33:45

by Alex Deucher

Subject: Re: [PATCH] drm/amdgpu/jpeg: Clean up errors in vcn_v1_0.c

Applied. Thanks!

On Wed, Aug 2, 2023 at 3:12 AM Ran Sun <[email protected]> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: space required before the open parenthesis '('
> ERROR: space prohibited after that '~' (ctx:WxW)
>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> index 16feb491adf5..25ba27151ac0 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v1_0.c
> @@ -473,7 +473,7 @@ static void vcn_v1_0_disable_clock_gating(struct amdgpu_device *adev)
> if (adev->cg_flags & AMD_CG_SUPPORT_VCN_MGCG)
> data |= 1 << UVD_CGC_CTRL__DYN_CLOCK_MODE__SHIFT;
> else
> - data &= ~ UVD_CGC_CTRL__DYN_CLOCK_MODE_MASK;
> + data &= ~UVD_CGC_CTRL__DYN_CLOCK_MODE_MASK;
>
> data |= 1 << UVD_CGC_CTRL__CLK_GATE_DLY_TIMER__SHIFT;
> data |= 4 << UVD_CGC_CTRL__CLK_OFF_DELAY__SHIFT;
> @@ -1772,7 +1772,7 @@ static int vcn_v1_0_set_powergating_state(void *handle,
> int ret;
> struct amdgpu_device *adev = (struct amdgpu_device *)handle;
>
> - if(state == adev->vcn.cur_state)
> + if (state == adev->vcn.cur_state)
> return 0;
>
> if (state == AMD_PG_STATE_GATE)
> @@ -1780,7 +1780,7 @@ static int vcn_v1_0_set_powergating_state(void *handle,
> else
> ret = vcn_v1_0_start(adev);
>
> - if(!ret)
> + if (!ret)
> adev->vcn.cur_state = state;
> return ret;
> }
> @@ -2065,8 +2065,7 @@ static void vcn_v1_0_set_irq_funcs(struct amdgpu_device *adev)
> adev->vcn.inst->irq.funcs = &vcn_v1_0_irq_funcs;
> }
>
> -const struct amdgpu_ip_block_version vcn_v1_0_ip_block =
> -{
> +const struct amdgpu_ip_block_version vcn_v1_0_ip_block = {
> .type = AMD_IP_BLOCK_TYPE_VCN,
> .major = 1,
> .minor = 0,
> --
> 2.17.1
>