2022-01-31 22:33:07

by Yang Li

Subject: [PATCH -next] drm/amd/display: clean up some inconsistent indenting

Eliminate the follow smatch warning:
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c:2246
dp_perform_8b_10b_link_training() warn: inconsistent indenting

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Yang Li <[email protected]>
---
drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index daaec3164875..34ffcd5bb1d7 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -2243,11 +2243,11 @@ static enum link_training_result dp_perform_8b_10b_link_training(

if (status == LINK_TRAINING_SUCCESS) {
status = perform_clock_recovery_sequence(link, link_res, lt_settings, DPRX);
- if (status == LINK_TRAINING_SUCCESS) {
- status = perform_channel_equalization_sequence(link,
- link_res,
- lt_settings,
- DPRX);
+ if (status == LINK_TRAINING_SUCCESS) {
+ status = perform_channel_equalization_sequence(link,
+ link_res,
+ lt_settings,
+ DPRX);
}
}

--
2.20.1.7.g153144c

2022-02-01 20:41:58

by Harry Wentland

Subject: Re: [PATCH -next] drm/amd/display: clean up some inconsistent indenting

On 2022-01-28 20:04, Yang Li wrote:
> Eliminate the follow smatch warning:
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c:2246
> dp_perform_8b_10b_link_training() warn: inconsistent indenting
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Yang Li <[email protected]>

Reviewed-by: Harry Wentland <[email protected]>

Harry

> ---
> drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index daaec3164875..34ffcd5bb1d7 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -2243,11 +2243,11 @@ static enum link_training_result dp_perform_8b_10b_link_training(
>
> if (status == LINK_TRAINING_SUCCESS) {
> status = perform_clock_recovery_sequence(link, link_res, lt_settings, DPRX);
> - if (status == LINK_TRAINING_SUCCESS) {
> - status = perform_channel_equalization_sequence(link,
> - link_res,
> - lt_settings,
> - DPRX);
> + if (status == LINK_TRAINING_SUCCESS) {
> + status = perform_channel_equalization_sequence(link,
> + link_res,
> + lt_settings,
> + DPRX);
> }
> }
>

2022-02-01 20:51:46

by Alex Deucher

Subject: Re: [PATCH -next] drm/amd/display: clean up some inconsistent indenting

Applied. Thanks!

Alex

On Mon, Jan 31, 2022 at 10:17 AM Harry Wentland <[email protected]> wrote:
>
> On 2022-01-28 20:04, Yang Li wrote:
> > Eliminate the follow smatch warning:
> > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c:2246
> > dp_perform_8b_10b_link_training() warn: inconsistent indenting
> >
> > Reported-by: Abaci Robot <[email protected]>
> > Signed-off-by: Yang Li <[email protected]>
>
> Reviewed-by: Harry Wentland <[email protected]>
>
> Harry
>
> > ---
> > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> > index daaec3164875..34ffcd5bb1d7 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> > @@ -2243,11 +2243,11 @@ static enum link_training_result dp_perform_8b_10b_link_training(
> >
> > if (status == LINK_TRAINING_SUCCESS) {
> > status = perform_clock_recovery_sequence(link, link_res, lt_settings, DPRX);
> > - if (status == LINK_TRAINING_SUCCESS) {
> > - status = perform_channel_equalization_sequence(link,
> > - link_res,
> > - lt_settings,
> > - DPRX);
> > + if (status == LINK_TRAINING_SUCCESS) {
> > + status = perform_channel_equalization_sequence(link,
> > + link_res,
> > + lt_settings,
> > + DPRX);
> > }
> > }
> >
>