2022-06-28 10:00:00

by Mauro Carvalho Chehab

Subject: [PATCH 13/22] drm: scheduler: add a missing kernel-doc parameter

Add a description for struct device at drm_sched_init(), in order
to solve this warning:

drivers/gpu/drm/scheduler/sched_main.c:999: warning: Function parameter or member 'dev' not described in 'drm_sched_init'

Signed-off-by: Mauro Carvalho Chehab <[email protected]>
---

To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
See [PATCH 00/22] at: https://lore.kernel.org/all/[email protected]/

drivers/gpu/drm/scheduler/sched_main.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
index 76fd2904c7c6..b45bd8473e9e 100644
--- a/drivers/gpu/drm/scheduler/sched_main.c
+++ b/drivers/gpu/drm/scheduler/sched_main.c
@@ -987,6 +987,7 @@ static int drm_sched_main(void *param)
* used
* @score: optional score atomic shared with other schedulers
* @name: name used for debugging
+ * @dev: pointer to struct device
*
* Return 0 on success, otherwise error code.
*/
--
2.36.1

2022-06-28 15:13:50

by Alex Deucher

Subject: Re: [PATCH 13/22] drm: scheduler: add a missing kernel-doc parameter

On Tue, Jun 28, 2022 at 5:46 AM Mauro Carvalho Chehab
<[email protected]> wrote:
>
> Add a description for struct device at drm_sched_init(), in order
> to solve this warning:
>
> drivers/gpu/drm/scheduler/sched_main.c:999: warning: Function parameter or member 'dev' not described in 'drm_sched_init'
>
> Signed-off-by: Mauro Carvalho Chehab <[email protected]>

Generally in the drm tree we use / rather than : in the patch titles. E.g.,

drm/scheduler: add a missing kernel-doc parameter

With that fixed:
Reviewed-by: Alex Deucher <[email protected]>


> ---
>
> To avoid mailbombing on a large number of people, only mailing lists were C/C on the cover.
> See [PATCH 00/22] at: https://lore.kernel.org/all/[email protected]/
>
> drivers/gpu/drm/scheduler/sched_main.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index 76fd2904c7c6..b45bd8473e9e 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -987,6 +987,7 @@ static int drm_sched_main(void *param)
> * used
> * @score: optional score atomic shared with other schedulers
> * @name: name used for debugging
> + * @dev: pointer to struct device
> *
> * Return 0 on success, otherwise error code.
> */
> --
> 2.36.1
>