2023-08-01 06:22:13

by Ran Sun

Subject: [PATCH] drm/amd/pm: Clean up errors in vega10_hwmgr.c

Fix the following errors reported by checkpatch:

ERROR: trailing statements should be on next line
ERROR: space required before the open brace '{'
ERROR: space required before the open parenthesis '('
ERROR: space required after that ',' (ctx:VxV)

Signed-off-by: Ran Sun <[email protected]>
---
.../drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 18 ++++++++++++------
1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
index 08518bc1cbbe..ba7294daddfe 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
@@ -670,17 +670,23 @@ static int vega10_patch_voltage_dependency_tables_with_lookup_table(
for (i = 0; i < 6; i++) {
struct phm_ppt_v1_clock_voltage_dependency_table *vdt;
switch (i) {
- case 0: vdt = table_info->vdd_dep_on_socclk;
+ case 0:
+ vdt = table_info->vdd_dep_on_socclk;
break;
- case 1: vdt = table_info->vdd_dep_on_sclk;
+ case 1:
+ vdt = table_info->vdd_dep_on_sclk;
break;
- case 2: vdt = table_info->vdd_dep_on_dcefclk;
+ case 2:
+ vdt = table_info->vdd_dep_on_dcefclk;
break;
- case 3: vdt = table_info->vdd_dep_on_pixclk;
+ case 3:
+ vdt = table_info->vdd_dep_on_pixclk;
break;
- case 4: vdt = table_info->vdd_dep_on_dispclk;
+ case 4:
+ vdt = table_info->vdd_dep_on_dispclk;
break;
- case 5: vdt = table_info->vdd_dep_on_phyclk;
+ case 5:
+ vdt = table_info->vdd_dep_on_phyclk;
break;
}

--
2.17.1

2023-08-07 16:44:53

by Alex Deucher

Subject: Re: [PATCH] drm/amd/pm: Clean up errors in vega10_hwmgr.c

This one doesn't apply due to whitespace differences.

Alex

On Tue, Aug 1, 2023 at 1:58 AM Ran Sun <[email protected]> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: trailing statements should be on next line
> ERROR: space required before the open brace '{'
> ERROR: space required before the open parenthesis '('
> ERROR: space required after that ',' (ctx:VxV)
>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> .../drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 18 ++++++++++++------
> 1 file changed, 12 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> index 08518bc1cbbe..ba7294daddfe 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> @@ -670,17 +670,23 @@ static int vega10_patch_voltage_dependency_tables_with_lookup_table(
> for (i = 0; i < 6; i++) {
> struct phm_ppt_v1_clock_voltage_dependency_table *vdt;
> switch (i) {
> - case 0: vdt = table_info->vdd_dep_on_socclk;
> + case 0:
> + vdt = table_info->vdd_dep_on_socclk;
> break;
> - case 1: vdt = table_info->vdd_dep_on_sclk;
> + case 1:
> + vdt = table_info->vdd_dep_on_sclk;
> break;
> - case 2: vdt = table_info->vdd_dep_on_dcefclk;
> + case 2:
> + vdt = table_info->vdd_dep_on_dcefclk;
> break;
> - case 3: vdt = table_info->vdd_dep_on_pixclk;
> + case 3:
> + vdt = table_info->vdd_dep_on_pixclk;
> break;
> - case 4: vdt = table_info->vdd_dep_on_dispclk;
> + case 4:
> + vdt = table_info->vdd_dep_on_dispclk;
> break;
> - case 5: vdt = table_info->vdd_dep_on_phyclk;
> + case 5:
> + vdt = table_info->vdd_dep_on_phyclk;
> break;
> }
>
> --
> 2.17.1
>