2023-08-02 08:35:33

by Ran Sun

Subject: [PATCH] drm/amdgpu: Clean up errors in vcn_v4_0.c

Fix the following errors reported by checkpatch:

spaces required around that '==' (ctx:VxV)
ERROR: space required before the open parenthesis '('
ERROR: that open brace { should be on the previous line

Signed-off-by: Ran Sun <[email protected]>
---
drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
index 6089c7deba8a..ef5b16061e96 100644
--- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
@@ -1139,11 +1139,11 @@ static int vcn_v4_0_start(struct amdgpu_device *adev)
if (status & 2)
break;
mdelay(10);
- if (amdgpu_emu_mode==1)
+ if (amdgpu_emu_mode == 1)
msleep(1);
}

- if (amdgpu_emu_mode==1) {
+ if (amdgpu_emu_mode == 1) {
r = -1;
if (status & 2) {
r = 0;
@@ -1959,7 +1959,7 @@ static int vcn_v4_0_set_powergating_state(void *handle, enum amd_powergating_sta
return 0;
}

- if(state == adev->vcn.cur_state)
+ if (state == adev->vcn.cur_state)
return 0;

if (state == AMD_PG_STATE_GATE)
@@ -1967,7 +1967,7 @@ static int vcn_v4_0_set_powergating_state(void *handle, enum amd_powergating_sta
else
ret = vcn_v4_0_start(adev);

- if(!ret)
+ if (!ret)
adev->vcn.cur_state = state;

return ret;
@@ -2101,8 +2101,7 @@ static const struct amd_ip_funcs vcn_v4_0_ip_funcs = {
.set_powergating_state = vcn_v4_0_set_powergating_state,
};

-const struct amdgpu_ip_block_version vcn_v4_0_ip_block =
-{
+const struct amdgpu_ip_block_version vcn_v4_0_ip_block = {
.type = AMD_IP_BLOCK_TYPE_VCN,
.major = 4,
.minor = 0,
--
2.17.1

2023-08-07 18:24:55

by Alex Deucher

Subject: Re: [PATCH] drm/amdgpu: Clean up errors in vcn_v4_0.c

Applied. Thanks!

On Wed, Aug 2, 2023 at 3:43 AM Ran Sun <[email protected]> wrote:
>
> Fix the following errors reported by checkpatch:
>
> spaces required around that '==' (ctx:VxV)
> ERROR: space required before the open parenthesis '('
> ERROR: that open brace { should be on the previous line
>
> Signed-off-by: Ran Sun <[email protected]>
> ---
> drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> index 6089c7deba8a..ef5b16061e96 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vcn_v4_0.c
> @@ -1139,11 +1139,11 @@ static int vcn_v4_0_start(struct amdgpu_device *adev)
> if (status & 2)
> break;
> mdelay(10);
> - if (amdgpu_emu_mode==1)
> + if (amdgpu_emu_mode == 1)
> msleep(1);
> }
>
> - if (amdgpu_emu_mode==1) {
> + if (amdgpu_emu_mode == 1) {
> r = -1;
> if (status & 2) {
> r = 0;
> @@ -1959,7 +1959,7 @@ static int vcn_v4_0_set_powergating_state(void *handle, enum amd_powergating_sta
> return 0;
> }
>
> - if(state == adev->vcn.cur_state)
> + if (state == adev->vcn.cur_state)
> return 0;
>
> if (state == AMD_PG_STATE_GATE)
> @@ -1967,7 +1967,7 @@ static int vcn_v4_0_set_powergating_state(void *handle, enum amd_powergating_sta
> else
> ret = vcn_v4_0_start(adev);
>
> - if(!ret)
> + if (!ret)
> adev->vcn.cur_state = state;
>
> return ret;
> @@ -2101,8 +2101,7 @@ static const struct amd_ip_funcs vcn_v4_0_ip_funcs = {
> .set_powergating_state = vcn_v4_0_set_powergating_state,
> };
>
> -const struct amdgpu_ip_block_version vcn_v4_0_ip_block =
> -{
> +const struct amdgpu_ip_block_version vcn_v4_0_ip_block = {
> .type = AMD_IP_BLOCK_TYPE_VCN,
> .major = 4,
> .minor = 0,
> --
> 2.17.1
>