2022-04-22 19:42:44

by Alex Deucher

[permalink] [raw]
Subject: Re: [PATCH] drm/amd/display: Fix memory leak in dcn21_clock_source_create

Applied. Thanks!

Alex

On Thu, Apr 21, 2022 at 5:03 AM Miaoqian Lin <[email protected]> wrote:
>
> When dcn20_clk_src_construct() fails, we need to release clk_src.
>
> Fixes: 6f4e6361c3ff ("drm/amd/display: Add Renoir resource (v2)")
> Signed-off-by: Miaoqian Lin <[email protected]>
> ---
> drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> index 3fe4bfbb98a0..faab59508d82 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> @@ -997,6 +997,7 @@ static struct clock_source *dcn21_clock_source_create(
> return &clk_src->base;
> }
>
> + kfree(clk_src);
> BREAK_TO_DEBUGGER();
> return NULL;
> }
> --
> 2.17.1
>