2023-02-09 12:53:37

by Colin Ian King

Subject: [PATCH][next] drm/amd/display: Fix spelling mistakes of function name in error message

The function name is being reported as dc_link_contruct when it is
actually dc_link_construct_phy. Fix this by using %s and the __func__
for the function name.

Signed-off-by: Colin Ian King <[email protected]>
---
drivers/gpu/drm/amd/display/dc/link/link_factory.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/link/link_factory.c b/drivers/gpu/drm/amd/display/dc/link/link_factory.c
index 13a766273755..3fc93fc593fb 100644
--- a/drivers/gpu/drm/amd/display/dc/link/link_factory.c
+++ b/drivers/gpu/drm/amd/display/dc/link/link_factory.c
@@ -452,7 +452,7 @@ static bool dc_link_construct_phy(struct dc_link *link,
link->psr_settings.psr_vtotal_control_support = false;
link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;

- DC_LOG_DC("BIOS object table - dc_link_contruct finished successfully.\n");
+ DC_LOG_DC("BIOS object table - %s finished successfully.\n", __func__);
return true;
device_tag_fail:
link->link_enc->funcs->destroy(&link->link_enc);
@@ -469,7 +469,7 @@ static bool dc_link_construct_phy(struct dc_link *link,
link->hpd_gpio = NULL;
}

- DC_LOG_DC("BIOS object table - dc_link_contruct failed.\n");
+ DC_LOG_DC("BIOS object table - %s failed.\n", __func__);
return false;
}

--
2.30.2

2023-02-09 14:36:04

by Alex Deucher

Subject: Re: [PATCH][next] drm/amd/display: Fix spelling mistakes of function name in error message

Applied. Thanks!

Alex

On Thu, Feb 9, 2023 at 7:53 AM Colin Ian King <[email protected]> wrote:
>
> The function name is being reported as dc_link_contruct when it is
> actually dc_link_construct_phy. Fix this by using %s and the __func__
> for the function name.
>
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/gpu/drm/amd/display/dc/link/link_factory.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/link/link_factory.c b/drivers/gpu/drm/amd/display/dc/link/link_factory.c
> index 13a766273755..3fc93fc593fb 100644
> --- a/drivers/gpu/drm/amd/display/dc/link/link_factory.c
> +++ b/drivers/gpu/drm/amd/display/dc/link/link_factory.c
> @@ -452,7 +452,7 @@ static bool dc_link_construct_phy(struct dc_link *link,
> link->psr_settings.psr_vtotal_control_support = false;
> link->psr_settings.psr_version = DC_PSR_VERSION_UNSUPPORTED;
>
> - DC_LOG_DC("BIOS object table - dc_link_contruct finished successfully.\n");
> + DC_LOG_DC("BIOS object table - %s finished successfully.\n", __func__);
> return true;
> device_tag_fail:
> link->link_enc->funcs->destroy(&link->link_enc);
> @@ -469,7 +469,7 @@ static bool dc_link_construct_phy(struct dc_link *link,
> link->hpd_gpio = NULL;
> }
>
> - DC_LOG_DC("BIOS object table - dc_link_contruct failed.\n");
> + DC_LOG_DC("BIOS object table - %s failed.\n", __func__);
> return false;
> }
>
> --
> 2.30.2
>