2017-09-20 07:14:09

by Arvind Yadav

Subject: [PATCH 0/2] Handle return value of devm_kasprintf

devm_kasprintf() can fail here and we must check its return value.

Arvind Yadav (2):
[PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf
[PATCH 2/2] gpio: tb10x: Handle return value of devm_kasprintf

drivers/gpio/gpio-brcmstb.c | 3 +++
drivers/gpio/gpio-tb10x.c | 3 +++
2 files changed, 6 insertions(+)

--
1.9.1

2017-09-20 07:14:16

by Arvind Yadav

Subject: [PATCH 2/2] gpio: tb10x: Handle return value of devm_kasprintf

devm_kasprintf() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/gpio/gpio-tb10x.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/gpio/gpio-tb10x.c b/drivers/gpio/gpio-tb10x.c
index 091ffaa..ac6f2a9 100644
--- a/drivers/gpio/gpio-tb10x.c
+++ b/drivers/gpio/gpio-tb10x.c
@@ -193,6 +193,9 @@ static int tb10x_gpio_probe(struct platform_device *pdev)

tb10x_gpio->gc.label =
devm_kasprintf(&pdev->dev, GFP_KERNEL, "%pOF", pdev->dev.of_node);
+ if (!tb10x_gpio->gc.label)
+ return -ENOMEM;
+
tb10x_gpio->gc.parent = &pdev->dev;
tb10x_gpio->gc.owner = THIS_MODULE;
tb10x_gpio->gc.direction_input = tb10x_gpio_direction_in;
--
1.9.1

2017-09-20 07:14:14

by Arvind Yadav

Subject: [PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf

devm_kasprintf() can fail here and we must check its return value.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/gpio/gpio-brcmstb.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
index dd0308c..1227d6e 100644
--- a/drivers/gpio/gpio-brcmstb.c
+++ b/drivers/gpio/gpio-brcmstb.c
@@ -485,6 +485,9 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
gc->of_node = np;
gc->owner = THIS_MODULE;
gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
+ if (!gc->label)
+ goto fail;
+
gc->base = gpio_base;
gc->of_gpio_n_cells = 2;
gc->of_xlate = brcmstb_gpio_of_xlate;
--
1.9.1

2017-09-21 03:25:26

by Gregory Fong

Subject: Re: [PATCH 1/2] gpio: brcmstb: Handle return value of devm_kasprintf

On Wed, Sep 20, 2017 at 12:13 AM, Arvind Yadav
<[email protected]> wrote:
> devm_kasprintf() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <[email protected]>
> ---
> drivers/gpio/gpio-brcmstb.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpio/gpio-brcmstb.c b/drivers/gpio/gpio-brcmstb.c
> index dd0308c..1227d6e 100644
> --- a/drivers/gpio/gpio-brcmstb.c
> +++ b/drivers/gpio/gpio-brcmstb.c
> @@ -485,6 +485,9 @@ static int brcmstb_gpio_probe(struct platform_device *pdev)
> gc->of_node = np;
> gc->owner = THIS_MODULE;
> gc->label = devm_kasprintf(dev, GFP_KERNEL, "%pOF", dev->of_node);
> + if (!gc->label)
> + goto fail;

Please also set err to -ENOMEM.

> +
> gc->base = gpio_base;
> gc->of_gpio_n_cells = 2;
> gc->of_xlate = brcmstb_gpio_of_xlate;
> --
> 1.9.1
>

Thanks,
Gregory

2017-09-21 12:14:41

by Linus Walleij

Subject: Re: [PATCH 2/2] gpio: tb10x: Handle return value of devm_kasprintf

On Wed, Sep 20, 2017 at 9:13 AM, Arvind Yadav <[email protected]> wrote:

> devm_kasprintf() can fail here and we must check its return value.
>
> Signed-off-by: Arvind Yadav <[email protected]>

Patch applied.

Yours,
Linus Walleij