2020-12-24 03:22:52

by Gene Chen

[permalink] [raw]
Subject: [PATCH resend] dt-bindings: mfd: mediatek: Add bindings for MT6360 PMIC

From: Gene Chen <[email protected]>

Add bindings for MT6360 PMIC

Signed-off-by: Gene Chen <[email protected]>
---
Documentation/devicetree/bindings/mfd/mt6360.yaml | 69 +++++++++++++++++++++++
1 file changed, 69 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/mt6360.yaml

diff --git a/Documentation/devicetree/bindings/mfd/mt6360.yaml b/Documentation/devicetree/bindings/mfd/mt6360.yaml
new file mode 100644
index 0000000..2781c31
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/mt6360.yaml
@@ -0,0 +1,69 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mfd/mt6360.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MT6360 PMIC from MediaTek Integrated
+
+maintainers:
+ - Gene Chen <[email protected]>
+
+description: |
+ MT6360 is a PMIC device with the following sub modules.
+ It is interfaced to host controller using I2C interface.
+
+ This document describes the binding for PMIC device and its sub module.
+
+properties:
+ compatible:
+ const: mediatek,mt6360
+
+ reg:
+ description:
+ I2C device address.
+ maxItems: 1
+
+ wakeup-source: true
+
+ interrupts:
+ maxItems: 1
+
+ interrupt-names:
+ enum:
+ - IRQB
+
+ interrupt-controller: true
+
+ "#interrupt-cells":
+ const: 1
+ description:
+ The first cell is the IRQ number.
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - interrupt-controller
+ - "#interrupt-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/irq.h>
+ #include <dt-bindings/regulator/mediatek,mt6360-regulator.h>
+ i2c {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ mt6360@34 {
+ compatible = "mediatek,mt6360";
+ reg = <0x34>;
+ wakeup-source;
+ interrupts-extended = <&gpio26 0 IRQ_TYPE_LEVEL_LOW>;
+ interrupt-names = "IRQB";
+ interrupt-controller;
+ #interrupt-cells = <1>;
+ };
+ };
--
2.7.4


2021-01-11 12:47:17

by Matti Vaittinen

[permalink] [raw]
Subject: Re: [PATCH resend] dt-bindings: mfd: mediatek: Add bindings for MT6360 PMIC

Hello Peeps,

On Thu, 2020-12-24 at 11:19 +0800, Gene Chen wrote:
> From: Gene Chen <[email protected]>
>
> Add bindings for MT6360 PMIC
>
> Signed-off-by: Gene Chen <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/mt6360.yaml | 69
> +++++++++++++++++++++++
> 1 file changed, 69 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/mt6360.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/mt6360.yaml
> b/Documentation/devicetree/bindings/mfd/mt6360.yaml
> new file mode 100644
> index 0000000..2781c31
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/mt6360.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/mt6360.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MT6360 PMIC from MediaTek Integrated
> +
> +maintainers:
> + - Gene Chen <[email protected]>
> +
> +description: |
> + MT6360 is a PMIC device with the following sub modules.
> + It is interfaced to host controller using I2C interface.
> +
> + This document describes the binding for PMIC device and its sub
> module.
> +
> +properties:
> + compatible:
> + const: mediatek,mt6360
> +
> + reg:
> + description:
> + I2C device address.
> + maxItems: 1
> +
> + wakeup-source: true
> +
> + interrupts:
> + maxItems: 1
> +
> + interrupt-names:
> + enum:
> + - IRQB
> +
> + interrupt-controller: true
> +
> + "#interrupt-cells":
> + const: 1
> + description:
> + The first cell is the IRQ number.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - interrupt-controller
> + - "#interrupt-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/regulator/mediatek,mt6360-regulator.h>
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + mt6360@34 {
> + compatible = "mediatek,mt6360";
> + reg = <0x34>;
> + wakeup-source;
> + interrupts-extended = <&gpio26 0 IRQ_TYPE_LEVEL_LOW>;
> + interrupt-names = "IRQB";
> + interrupt-controller;
> + #interrupt-cells = <1>;

Out of the curiosity - is this the complete node? I would assume some
sub-devices like regulators here?

> + };
> + };

2021-01-11 13:09:03

by Gene Chen

[permalink] [raw]
Subject: Re: [PATCH resend] dt-bindings: mfd: mediatek: Add bindings for MT6360 PMIC

Vaittinen, Matti <[email protected]> 於 2021年1月11日 週一 下午5:13寫道:
>
> Hello Peeps,
>
> On Thu, 2020-12-24 at 11:19 +0800, Gene Chen wrote:
> > From: Gene Chen <[email protected]>
> >
> > Add bindings for MT6360 PMIC
> >
> > Signed-off-by: Gene Chen <[email protected]>
> > ---
> > Documentation/devicetree/bindings/mfd/mt6360.yaml | 69
> > +++++++++++++++++++++++
> > 1 file changed, 69 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/mfd/mt6360.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/mt6360.yaml
> > b/Documentation/devicetree/bindings/mfd/mt6360.yaml
> > new file mode 100644
> > index 0000000..2781c31
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/mt6360.yaml
> > @@ -0,0 +1,69 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mfd/mt6360.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MT6360 PMIC from MediaTek Integrated
> > +
> > +maintainers:
> > + - Gene Chen <[email protected]>
> > +
> > +description: |
> > + MT6360 is a PMIC device with the following sub modules.
> > + It is interfaced to host controller using I2C interface.
> > +
> > + This document describes the binding for PMIC device and its sub
> > module.
> > +
> > +properties:
> > + compatible:
> > + const: mediatek,mt6360
> > +
> > + reg:
> > + description:
> > + I2C device address.
> > + maxItems: 1
> > +
> > + wakeup-source: true
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + interrupt-names:
> > + enum:
> > + - IRQB
> > +
> > + interrupt-controller: true
> > +
> > + "#interrupt-cells":
> > + const: 1
> > + description:
> > + The first cell is the IRQ number.
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - interrupts
> > + - interrupt-controller
> > + - "#interrupt-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/irq.h>
> > + #include <dt-bindings/regulator/mediatek,mt6360-regulator.h>
> > + i2c {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + mt6360@34 {
> > + compatible = "mediatek,mt6360";
> > + reg = <0x34>;
> > + wakeup-source;
> > + interrupts-extended = <&gpio26 0 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-names = "IRQB";
> > + interrupt-controller;
> > + #interrupt-cells = <1>;
>
> Out of the curiosity - is this the complete node? I would assume some
> sub-devices like regulators here?
>

After all sub-devices module review done, I will add new patch to add
reference description.
e.g. max77650.yaml
leds:
$ref: ../leds/leds-max77650.yaml

> > + };
> > + };
>

2022-04-22 18:55:18

by Rob Herring

[permalink] [raw]
Subject: Re: [PATCH resend] dt-bindings: mfd: mediatek: Add bindings for MT6360 PMIC

On Thu, Dec 24, 2020 at 11:19:49AM +0800, Gene Chen wrote:
> From: Gene Chen <[email protected]>
>
> Add bindings for MT6360 PMIC
>
> Signed-off-by: Gene Chen <[email protected]>
> ---
> Documentation/devicetree/bindings/mfd/mt6360.yaml | 69 +++++++++++++++++++++++
> 1 file changed, 69 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/mt6360.yaml

Applying this old patch as "mediatek,mt6360" is used, but not documented
(causing warnings). Please send a follow-up patch adding the child
nodes as promised.

Rob