2022-08-09 06:43:18

by Satya Priya

Subject: [PATCH V4 1/3] arm64: dts: qcom: sc7280: Cleanup the lpasscc node

Remove "cc" regmap from lpasscc node which is overlapping
with the lpass_aon regmap.

Fixes: 422a295221bb ("arm64: dts: qcom: sc7280: Add clock controller nodes")
Signed-off-by: Satya Priya <[email protected]>
Signed-off-by: Taniya Das <[email protected]>
---
Changes since v3:
- None.

Changes since v2:
- Cleanup the lpasscc node to handle regmap overlap with lpass_aon
instead of disabling the lpasscc node.
- This patch is added in v3.

arch/arm64/boot/dts/qcom/sc7280.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
index 13d7f26..71735bb 100644
--- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
@@ -2168,9 +2168,8 @@
lpasscc: lpasscc@3000000 {
compatible = "qcom,sc7280-lpasscc";
reg = <0 0x03000000 0 0x40>,
- <0 0x03c04000 0 0x4>,
- <0 0x03389000 0 0x24>;
- reg-names = "qdsp6ss", "top_cc", "cc";
+ <0 0x03c04000 0 0x4>;
+ reg-names = "qdsp6ss", "top_cc";
clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>;
clock-names = "iface";
#clock-cells = <1>;
--
2.7.4

2022-08-09 16:38:52

by Stephen Boyd

Subject: Re: [PATCH V4 1/3] arm64: dts: qcom: sc7280: Cleanup the lpasscc node

Quoting Satya Priya (2022-08-08 23:35:07)
> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> index 13d7f26..71735bb 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> @@ -2168,9 +2168,8 @@
> lpasscc: lpasscc@3000000 {
> compatible = "qcom,sc7280-lpasscc";
> reg = <0 0x03000000 0 0x40>,
> - <0 0x03c04000 0 0x4>,
> - <0 0x03389000 0 0x24>;
> - reg-names = "qdsp6ss", "top_cc", "cc";
> + <0 0x03c04000 0 0x4>;

This looks oddly tabbed out? I'd expect it to align with the first reg
property, so be unchanged.

> + reg-names = "qdsp6ss", "top_cc";
> clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>;
> clock-names = "iface";

2022-08-10 05:07:52

by Satya Priya

Subject: Re: [PATCH V4 1/3] arm64: dts: qcom: sc7280: Cleanup the lpasscc node

On 8/9/2022 10:04 PM, Stephen Boyd wrote:
> Quoting Satya Priya (2022-08-08 23:35:07)
>> diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> index 13d7f26..71735bb 100644
>> --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
>> @@ -2168,9 +2168,8 @@
>> lpasscc: lpasscc@3000000 {
>> compatible = "qcom,sc7280-lpasscc";
>> reg = <0 0x03000000 0 0x40>,
>> - <0 0x03c04000 0 0x4>,
>> - <0 0x03389000 0 0x24>;
>> - reg-names = "qdsp6ss", "top_cc", "cc";
>> + <0 0x03c04000 0 0x4>;
> This looks oddly tabbed out? I'd expect it to align with the first reg
> property, so be unchanged.


Okay, I will correct the tabbing. But this wouldn't remain unchanged
because the comma is being replaced by semi-colon.


>> + reg-names = "qdsp6ss", "top_cc";
>> clocks = <&gcc GCC_CFG_NOC_LPASS_CLK>;
>> clock-names = "iface";