Add RocketLake platform support and other driver maintainance.
Gayatri Kammela (4):
platform/x86: intel_pmc_core: Clean up: Remove the duplicate comments
and reorganize
platform/x86: intel_pmc_core: Add Intel RocketLake (RKL) support
platform/x86: intel_pmc_core: fix: Replace dev_dbg macro with
dev_info()
MAINTAINERS: Update maintainers for pmc_core driver
MAINTAINERS | 4 +--
drivers/platform/x86/intel_pmc_core.c | 39 ++++++++++++++++-----------
2 files changed, 26 insertions(+), 17 deletions(-)
--
2.20.1
From: Gayatri Kammela <[email protected]>
Add RocketLake to the list of the platforms that intel_pmc_core driver
supports for pmc_core device. RocketLake reuses all the TigerLake PCH IPs.
Cc: Srinivas Pandruvada <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: David E. Box <[email protected]>
Cc: Tony Luck <[email protected]>
Cc: Rui Zhang <[email protected]>
Signed-off-by: Gayatri Kammela <[email protected]>
Signed-off-by: David E. Box <[email protected]>
---
drivers/platform/x86/intel_pmc_core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
index d959fa698ec5..f0347ee8a4d6 100644
--- a/drivers/platform/x86/intel_pmc_core.c
+++ b/drivers/platform/x86/intel_pmc_core.c
@@ -1155,6 +1155,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = {
X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE, &tgl_reg_map),
X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT, &tgl_reg_map),
X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L, &icl_reg_map),
+ X86_MATCH_INTEL_FAM6_MODEL(ROCKETLAKE, &tgl_reg_map),
{}
};
--
2.20.1
From: Gayatri Kammela <[email protected]>
Update MAINTAINERS file for pmc_core driver to reflect the current
maintainers.
Cc: Vishwanath Somayaji <[email protected]>
Cc: Andy Shevchenko <[email protected]>
Cc: Srinivas Pandruvada <[email protected]>
Cc: David E. Box <[email protected]>
Acked-by: David E. Box <[email protected]>
Acked-by: Vishwanath Somayaji <[email protected]>
Signed-off-by: Gayatri Kammela <[email protected]>
Signed-off-by: David E. Box <[email protected]>
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 33b27e62ce19..cd9fcea0d507 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -8925,8 +8925,8 @@ F: arch/x86/include/asm/intel_punit_ipc.h
F: drivers/platform/x86/intel_punit_ipc.c
INTEL PMC CORE DRIVER
-M: Rajneesh Bhardwaj <[email protected]>
-M: Vishwanath Somayaji <[email protected]>
+M: Rajneesh Bhardwaj <[email protected]>
+M: David E Box <[email protected]>
L: [email protected]
S: Maintained
F: drivers/platform/x86/intel_pmc_core*
--
2.20.1
On Tue, Oct 6, 2020 at 11:51 PM David E. Box
<[email protected]> wrote:
>
> From: Gayatri Kammela <[email protected]>
>
> Add RocketLake to the list of the platforms that intel_pmc_core driver
> supports for pmc_core device. RocketLake reuses all the TigerLake PCH IPs.
Just a nit here - I guess the convention was to leave a space in IP
names such as "Tiger Lake", "Rocket Lake" like it's done in previous
patches too. I am not sure whether it's a new convention but it's good
to be consistent throughout the series.
Other than that, the series is:
Reviewed-by: Rajneesh Bhardwaj <[email protected]>
>
>
> Cc: Srinivas Pandruvada <[email protected]>
> Cc: Andy Shevchenko <[email protected]>
> Cc: David E. Box <[email protected]>
> Cc: Tony Luck <[email protected]>
> Cc: Rui Zhang <[email protected]>
> Signed-off-by: Gayatri Kammela <[email protected]>
> Signed-off-by: David E. Box <[email protected]>
> ---
> drivers/platform/x86/intel_pmc_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c
> index d959fa698ec5..f0347ee8a4d6 100644
> --- a/drivers/platform/x86/intel_pmc_core.c
> +++ b/drivers/platform/x86/intel_pmc_core.c
> @@ -1155,6 +1155,7 @@ static const struct x86_cpu_id intel_pmc_core_ids[] = {
> X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE, &tgl_reg_map),
> X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT, &tgl_reg_map),
> X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L, &icl_reg_map),
> + X86_MATCH_INTEL_FAM6_MODEL(ROCKETLAKE, &tgl_reg_map),
> {}
> };
>
> --
> 2.20.1
>
--
Thanks,
Rajneesh
On Wed, Oct 7, 2020 at 6:51 AM David E. Box <[email protected]> wrote:
>
> Add RocketLake platform support and other driver maintainance.
Hans, Mark, this series has been internally reviewed and tested on
affected hardware, I think it's ready to go for v5.10.
Reviewed-by: Andy Shevchenko <[email protected]>
David, I'm not a maintainer anymore here.
> Gayatri Kammela (4):
> platform/x86: intel_pmc_core: Clean up: Remove the duplicate comments
> and reorganize
> platform/x86: intel_pmc_core: Add Intel RocketLake (RKL) support
> platform/x86: intel_pmc_core: fix: Replace dev_dbg macro with
> dev_info()
> MAINTAINERS: Update maintainers for pmc_core driver
>
> MAINTAINERS | 4 +--
> drivers/platform/x86/intel_pmc_core.c | 39 ++++++++++++++++-----------
> 2 files changed, 26 insertions(+), 17 deletions(-)
>
> --
> 2.20.1
>
--
With Best Regards,
Andy Shevchenko
Hi,
On 10/7/20 5:51 AM, David E. Box wrote:
> Add RocketLake platform support and other driver maintainance.
>
> Gayatri Kammela (4):
> platform/x86: intel_pmc_core: Clean up: Remove the duplicate comments
> and reorganize
> platform/x86: intel_pmc_core: Add Intel RocketLake (RKL) support
> platform/x86: intel_pmc_core: fix: Replace dev_dbg macro with
> dev_info()
> MAINTAINERS: Update maintainers for pmc_core driver
Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans
Note it will show up there once I've pushed my local branch there,
which might take a while.
Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.
Regards,
Hans