2021-03-04 16:55:04

by Andy Shevchenko

Subject: Re: [PATCH v4 05/15] pinctrl: add a pincontrol driver for BCM6328

On Thu, Mar 4, 2021 at 1:13 PM Álvaro Fernández Rojas <[email protected]> wrote:
> > El 4 mar 2021, a las 11:49, Andy Shevchenko <[email protected]> escribió:
> > On Thu, Mar 4, 2021 at 10:57 AM Álvaro Fernández Rojas
> > <[email protected]> wrote:

...

> >> + static const unsigned int bcm6328_mux[] = {
> >> + BCM6328_MUX_LO_REG,
> >> + BCM6328_MUX_HI_REG,
> >
> >> + BCM6328_MUX_OTHER_REG
> >
> > When it's not terminator add a comma, otherwise remove a comma.

> … so you want me to add a comma or not?

Hmm... you tell me! If this is a list which covers all possible cases
_and_ the last one is the kinda maximum value (aka terminator), then
comma is not needed, otherwise add it (to me feels like the latter
should be done here).

> > Also, why is it inside a function? It's anyway global and constant.
>
> Because this is only used by this function and I’m used to doing this to comply with MISRA C 2004 at work :)

It makes code a bit harder to read.

> >> + };

--
With Best Regards,
Andy Shevchenko

2021-03-05 00:12:22

by Álvaro Fernández Rojas

Subject: Re: [PATCH v4 05/15] pinctrl: add a pincontrol driver for BCM6328

> El 4 mar 2021, a las 13:12, Andy Shevchenko <[email protected]> escribió:
>
> On Thu, Mar 4, 2021 at 1:13 PM Álvaro Fernández Rojas <[email protected]> wrote:
>>> El 4 mar 2021, a las 11:49, Andy Shevchenko <[email protected]> escribió:
>>> On Thu, Mar 4, 2021 at 10:57 AM Álvaro Fernández Rojas
>>> <[email protected]> wrote:
>
> ...
>
>>>> + static const unsigned int bcm6328_mux[] = {
>>>> + BCM6328_MUX_LO_REG,
>>>> + BCM6328_MUX_HI_REG,
>>>
>>>> + BCM6328_MUX_OTHER_REG
>>>
>>> When it's not terminator add a comma, otherwise remove a comma.
>
>> … so you want me to add a comma or not?
>
> Hmm... you tell me! If this is a list which covers all possible cases
> _and_ the last one is the kinda maximum value (aka terminator), then
> comma is not needed, otherwise add it (to me feels like the latter
> should be done here).

Well… Then it shouldn’t be needed, since this is a list which covers all possible cases and the last one is a terminator.

>
>>> Also, why is it inside a function? It's anyway global and constant.
>>
>> Because this is only used by this function and I’m used to doing this to comply with MISRA C 2004 at work :)
>
> It makes code a bit harder to read.

Ok, I will make it global in the next version.

>
>>>> + };
>
> --
> With Best Regards,
> Andy Shevchenko