2015-11-03 00:00:23

by Brendan Gregg

[permalink] [raw]
Subject: Re: [RFC/PATCH 3/3] perf tools: Defaults to 'caller' callchain order only if --children is enabled

On Thu, Oct 22, 2015 at 7:03 AM, Arnaldo Carvalho de Melo
<[email protected]> wrote:
> Em Thu, Oct 22, 2015 at 02:49:11AM -0700, Brendan Gregg escreveu:
>> On Thu, Oct 22, 2015 at 12:38 AM, Namhyung Kim <[email protected]> wrote:
>> > Hi Ingo,
>> >
>> > On Thu, Oct 22, 2015 at 4:32 PM, Ingo Molnar <[email protected]> wrote:
>> >>
>> >> * Namhyung Kim <[email protected]> wrote:
>> >>
>> >>> The caller callchain order is useful with --children option since it can
>> >>> show 'overview' style output, but other commands which don't use
>> >>> --children feature like 'perf script' or even 'perf report/top' without
>> >>> --children are better to keep caller order.
>> >
>> > Oops, there's a typo: s/caller order/callee order/ :)
>>
>> Thanks, I was wondering about that (and I've made that typo myself).
>> Thanks for the patch!
>
> Brendan, can I take that as an Acked-by?

Belated, yes!

Brendan