2020-11-01 15:38:46

by Tom Rix

Subject: [PATCH] net: core: remove unneeded semicolon

From: Tom Rix <[email protected]>

A semicolon is not needed after a switch statement.

Signed-off-by: Tom Rix <[email protected]>
---
net/core/dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index 751e5264fd49..10f5d0c3d0d7 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -8898,7 +8898,7 @@ static bpf_op_t dev_xdp_bpf_op(struct net_device *dev, enum bpf_xdp_mode mode)
return dev->netdev_ops->ndo_bpf;
default:
return NULL;
- };
+ }
}

static struct bpf_xdp_link *dev_xdp_link(struct net_device *dev,
--
2.18.1

2020-11-02 19:02:10

by Andrii Nakryiko

Subject: Re: [PATCH] net: core: remove unneeded semicolon

On Sun, Nov 1, 2020 at 7:38 AM <[email protected]> wrote:
>
> From: Tom Rix <[email protected]>
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix <[email protected]>
> ---

Yep.

Acked-by: Andrii Nakryiko <[email protected]>

> net/core/dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 751e5264fd49..10f5d0c3d0d7 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -8898,7 +8898,7 @@ static bpf_op_t dev_xdp_bpf_op(struct net_device *dev, enum bpf_xdp_mode mode)
> return dev->netdev_ops->ndo_bpf;
> default:
> return NULL;
> - };
> + }
> }
>
> static struct bpf_xdp_link *dev_xdp_link(struct net_device *dev,
> --
> 2.18.1
>

2020-11-03 01:56:19

by Jakub Kicinski

Subject: Re: [PATCH] net: core: remove unneeded semicolon

On Sun, 1 Nov 2020 07:36:47 -0800 [email protected] wrote:
> From: Tom Rix <[email protected]>
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix <[email protected]>

Applied...