2021-09-02 14:53:13

by Mark Brown

[permalink] [raw]

Subject: Re: [PATCH 1/2] ASoC: SOF: imx: Add code to manage DSP related clocks

---

On Thu, Sep 02, 2021 at 03:32:15PM +0300, Daniel Baluta wrote:

> + for (i = 0; i < clks->num_dsp_clks; i++) {
> + clks->dsp_clks[i] = devm_clk_get(sdev->dev, clks->dsp_clks_names[i]);

Looks like this could benefit from the use of the clk_bulk_ APIs?

---

Attachments:

(No filename) (259.00 B)
signature.asc (499.00 B)
Download all attachments

2021-09-03 16:15:26

by Daniel Baluta

[permalink] [raw]

Subject: Re: [PATCH 1/2] ASoC: SOF: imx: Add code to manage DSP related clocks

---

On Fri, Sep 3, 2021 at 2:27 AM Mark Brown <[email protected]> wrote:
>
> On Thu, Sep 02, 2021 at 03:32:15PM +0300, Daniel Baluta wrote:
>
> > + for (i = 0; i < clks->num_dsp_clks; i++) {
> > + clks->dsp_clks[i] = devm_clk_get(sdev->dev, clks->dsp_clks_names[i]);
>
> Looks like this could benefit from the use of the clk_bulk_ APIs?

Indeed! I open coded exactly what clk_bulk API is doing! Will use it in v2.