2019-07-03 12:11:03

by Abel Vesa

Subject: [PATCH v2] arm64: dts: imx8mm: Init rates and parents configs for clocks

Add the initial configuration for clocks that need default parent and rate
setting. This is based on the vendor tree clock provider parents and rates
configuration except this is doing the setup in dts rather than using clock
consumer API in a clock provider driver.

Signed-off-by: Abel Vesa <[email protected]>
---

Changes since v1:
- removed the PCIE, CSI and DISP clocks parent setting since
that should be done from their driver.

arch/arm64/boot/dts/freescale/imx8mm.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
index 232a741..ba2034d 100644
--- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
@@ -451,6 +451,17 @@
<&clk_ext3>, <&clk_ext4>;
clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2",
"clk_ext3", "clk_ext4";
+ assigned-clocks = <&clk IMX8MM_CLK_NOC>,
+ <&clk IMX8MM_CLK_AUDIO_AHB>,
+ <&clk IMX8MM_CLK_IPG_AUDIO_ROOT>,
+ <&clk IMX8MM_SYS_PLL3>,
+ <&clk IMX8MM_VIDEO_PLL1>;
+ assigned-clock-parents = <&clk IMX8MM_SYS_PLL3_OUT>,
+ <&clk IMX8MM_SYS_PLL1_800M>;
+ assigned-clock-rates = <0>,
+ <400000000>,
+ <750000000>,
+ <594000000>;
};

src: reset-controller@30390000 {
--
2.7.4

2019-07-03 13:07:38

by Daniel Baluta

Subject: Re: [PATCH v2] arm64: dts: imx8mm: Init rates and parents configs for clocks

On Wed, Jul 3, 2019 at 3:10 PM Abel Vesa <[email protected]> wrote:
>
> Add the initial configuration for clocks that need default parent and rate
> setting. This is based on the vendor tree clock provider parents and rates
> configuration except this is doing the setup in dts rather than using clock
> consumer API in a clock provider driver.
>
> Signed-off-by: Abel Vesa <[email protected]>

Thanks Abel, this helps audio. For audio clk:

Acked-by: Daniel Baluta <[email protected]>

> ---
>
> Changes since v1:
> - removed the PCIE, CSI and DISP clocks parent setting since
> that should be done from their driver.
>
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index 232a741..ba2034d 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -451,6 +451,17 @@
> <&clk_ext3>, <&clk_ext4>;
> clock-names = "osc_32k", "osc_24m", "clk_ext1", "clk_ext2",
> "clk_ext3", "clk_ext4";
> + assigned-clocks = <&clk IMX8MM_CLK_NOC>,
> + <&clk IMX8MM_CLK_AUDIO_AHB>,
> + <&clk IMX8MM_CLK_IPG_AUDIO_ROOT>,
> + <&clk IMX8MM_SYS_PLL3>,
> + <&clk IMX8MM_VIDEO_PLL1>;
> + assigned-clock-parents = <&clk IMX8MM_SYS_PLL3_OUT>,
> + <&clk IMX8MM_SYS_PLL1_800M>;
> + assigned-clock-rates = <0>,
> + <400000000>,
> + <750000000>,
> + <594000000>;
> };
>
> src: reset-controller@30390000 {
> --
> 2.7.4
>

2019-07-18 06:16:29

by Shawn Guo

Subject: Re: [PATCH v2] arm64: dts: imx8mm: Init rates and parents configs for clocks

On Wed, Jul 03, 2019 at 03:08:22PM +0300, Abel Vesa wrote:
> Add the initial configuration for clocks that need default parent and rate
> setting. This is based on the vendor tree clock provider parents and rates
> configuration except this is doing the setup in dts rather than using clock
> consumer API in a clock provider driver.
>
> Signed-off-by: Abel Vesa <[email protected]>

Applied, thanks.