From: Yinghai Lu <[email protected]>
Date: Tue, 31 Mar 2015 19:57:46 -0700
> Fix regression by commit d63e2e1f3df9 ("sparc/PCI: Clip bridge windows to
> fit in upstream windows").
>
> That cause bridge bar get clipped wrongly.
>
> The sparc64 dma_addr_t is 32-bit, we can not use it to check if we can
> use 64bit bar, introduce pci_bus_addr_t.
>
> sparc ofpci does not parse 64bit mem for root bus, add code to
> make sure that we get correct resource for root.
>
> Also there are device 64-bit res does not have pref bit flag, but bridges
> do have pref bit set, that cause extra "no compatible window".
> Set pref bit for them according to the errata.
Just to be clear, who is going to merge this? :-)
On Thu, Apr 2, 2015 at 1:37 PM, David Miller <[email protected]> wrote:
> From: Yinghai Lu <[email protected]>
> Date: Tue, 31 Mar 2015 19:57:46 -0700
>
>> Fix regression by commit d63e2e1f3df9 ("sparc/PCI: Clip bridge windows to
>> fit in upstream windows").
>>
>> That cause bridge bar get clipped wrongly.
>>
>> The sparc64 dma_addr_t is 32-bit, we can not use it to check if we can
>> use 64bit bar, introduce pci_bus_addr_t.
>>
>> sparc ofpci does not parse 64bit mem for root bus, add code to
>> make sure that we get correct resource for root.
>>
>> Also there are device 64-bit res does not have pref bit flag, but bridges
>> do have pref bit set, that cause extra "no compatible window".
>> Set pref bit for them according to the errata.
>
> Just to be clear, who is going to merge this? :-)
>
Should be you or Bjorn, but one should get ack from another.
Thanks
Yinghai
On Thu, Apr 2, 2015 at 5:07 PM, Yinghai Lu <[email protected]> wrote:
> On Thu, Apr 2, 2015 at 1:37 PM, David Miller <[email protected]> wrote:
>> From: Yinghai Lu <[email protected]>
>> Date: Tue, 31 Mar 2015 19:57:46 -0700
>>
>>> Fix regression by commit d63e2e1f3df9 ("sparc/PCI: Clip bridge windows to
>>> fit in upstream windows").
>>>
>>> That cause bridge bar get clipped wrongly.
>>>
>>> The sparc64 dma_addr_t is 32-bit, we can not use it to check if we can
>>> use 64bit bar, introduce pci_bus_addr_t.
>>>
>>> sparc ofpci does not parse 64bit mem for root bus, add code to
>>> make sure that we get correct resource for root.
>>>
>>> Also there are device 64-bit res does not have pref bit flag, but bridges
>>> do have pref bit set, that cause extra "no compatible window".
>>> Set pref bit for them according to the errata.
>>
>> Just to be clear, who is going to merge this? :-)
>>
>
> Should be you or Bjorn, but one should get ack from another.
I'm just getting back from vacation and would like to have a chance to
look over this.
One first reaction is that if we add a pci_bus_addr_t,
Documentation/DMA-API-HOWTO.txt needs to be updated. It currently
says a dma_addr_t "can hold any valid DMA or bus address."
Bjorn
From: Yinghai Lu <[email protected]>
Date: Thu, 2 Apr 2015 15:07:57 -0700
> On Thu, Apr 2, 2015 at 1:37 PM, David Miller <[email protected]> wrote:
>> From: Yinghai Lu <[email protected]>
>> Date: Tue, 31 Mar 2015 19:57:46 -0700
>>
>>> Fix regression by commit d63e2e1f3df9 ("sparc/PCI: Clip bridge windows to
>>> fit in upstream windows").
>>>
>>> That cause bridge bar get clipped wrongly.
>>>
>>> The sparc64 dma_addr_t is 32-bit, we can not use it to check if we can
>>> use 64bit bar, introduce pci_bus_addr_t.
>>>
>>> sparc ofpci does not parse 64bit mem for root bus, add code to
>>> make sure that we get correct resource for root.
>>>
>>> Also there are device 64-bit res does not have pref bit flag, but bridges
>>> do have pref bit set, that cause extra "no compatible window".
>>> Set pref bit for them according to the errata.
>>
>> Just to be clear, who is going to merge this? :-)
>>
>
> Should be you or Bjorn, but one should get ack from another.
Acked-by: David S. Miller <[email protected]>