2015-06-18 22:11:37

by Duc Dang

Subject: [PATCH 1/1] pci: xgene: Fix compilation warning

commit 979595bcb8da ("PCI: xgene: Allow config access to Root Port even
when link is down") removes the port->link_up check, which makes 'port'
become unused variable. This patch remove struct xgene_pcie_port *port
declaration to avoid compilation warning.

Signed-off-by: Duc Dang <[email protected]>
Signed-off-by: Tanmay Inamdar <[email protected]>
---
drivers/pci/host/pci-xgene.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
index 3684126..105fd83 100644
--- a/drivers/pci/host/pci-xgene.c
+++ b/drivers/pci/host/pci-xgene.c
@@ -137,8 +137,6 @@ static bool xgene_pcie_hide_rc_bars(struct pci_bus *bus, int offset)
static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
int offset)
{
- struct xgene_pcie_port *port = bus->sysdata;
-
if ((pci_is_root_bus(bus) && devfn != 0) ||
xgene_pcie_hide_rc_bars(bus, offset))
return NULL;
--
1.9.1

2015-06-18 22:58:45

by Bjorn Helgaas

Subject: Re: [PATCH 1/1] pci: xgene: Fix compilation warning

On Thu, Jun 18, 2015 at 5:10 PM, Duc Dang <[email protected]> wrote:
> commit 979595bcb8da ("PCI: xgene: Allow config access to Root Port even
> when link is down") removes the port->link_up check, which makes 'port'
> become unused variable. This patch remove struct xgene_pcie_port *port
> declaration to avoid compilation warning.
>
> Signed-off-by: Duc Dang <[email protected]>
> Signed-off-by: Tanmay Inamdar <[email protected]>

I folded this fix into the original patch and updated my branch. Thanks!

> ---
> drivers/pci/host/pci-xgene.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
> index 3684126..105fd83 100644
> --- a/drivers/pci/host/pci-xgene.c
> +++ b/drivers/pci/host/pci-xgene.c
> @@ -137,8 +137,6 @@ static bool xgene_pcie_hide_rc_bars(struct pci_bus *bus, int offset)
> static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
> int offset)
> {
> - struct xgene_pcie_port *port = bus->sysdata;
> -
> if ((pci_is_root_bus(bus) && devfn != 0) ||
> xgene_pcie_hide_rc_bars(bus, offset))
> return NULL;
> --
> 1.9.1
>

2015-06-19 02:39:47

by Duc Dang

Subject: Re: [PATCH 1/1] pci: xgene: Fix compilation warning

On Thu, Jun 18, 2015 at 3:57 PM, Bjorn Helgaas <[email protected]> wrote:
> On Thu, Jun 18, 2015 at 5:10 PM, Duc Dang <[email protected]> wrote:
>> commit 979595bcb8da ("PCI: xgene: Allow config access to Root Port even
>> when link is down") removes the port->link_up check, which makes 'port'
>> become unused variable. This patch remove struct xgene_pcie_port *port
>> declaration to avoid compilation warning.
>>
>> Signed-off-by: Duc Dang <[email protected]>
>> Signed-off-by: Tanmay Inamdar <[email protected]>
>
> I folded this fix into the original patch and updated my branch. Thanks!

Thanks, Bjorn.
>
>> ---
>> drivers/pci/host/pci-xgene.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/pci/host/pci-xgene.c b/drivers/pci/host/pci-xgene.c
>> index 3684126..105fd83 100644
>> --- a/drivers/pci/host/pci-xgene.c
>> +++ b/drivers/pci/host/pci-xgene.c
>> @@ -137,8 +137,6 @@ static bool xgene_pcie_hide_rc_bars(struct pci_bus *bus, int offset)
>> static void __iomem *xgene_pcie_map_bus(struct pci_bus *bus, unsigned int devfn,
>> int offset)
>> {
>> - struct xgene_pcie_port *port = bus->sysdata;
>> -
>> if ((pci_is_root_bus(bus) && devfn != 0) ||
>> xgene_pcie_hide_rc_bars(bus, offset))
>> return NULL;
>> --
>> 1.9.1
>>



--
Regards,
Duc Dang.