2012-08-01 14:21:03

by Bjorn Helgaas

Subject: Re: [PATCH] Fix priority of non-BAR ROM data

On Sun, Jul 29, 2012 at 3:53 PM, Matthew Garrett <[email protected]> wrote:
> On Sun, Jul 29, 2012 at 10:49:42PM +0100, David Woodhouse wrote:
>> + * Some devices may provide ROMs via a source other than the BAR
>> + */
>> + if (pdev->rom && pdev->romlen) {
>> + *size = pdev->romlen;
>> + return phys_to_virt(pdev->rom);
>
> Needs casting. My mistake.

Matthew, are you going to fold this into your patch and repost your
series, or is this a logically separate issue?

2012-08-01 14:26:37

by Matthew Garrett

Subject: Re: [PATCH] Fix priority of non-BAR ROM data

On Wed, Aug 01, 2012 at 08:20:15AM -0600, Bjorn Helgaas wrote:
> On Sun, Jul 29, 2012 at 3:53 PM, Matthew Garrett <[email protected]> wrote:
> > On Sun, Jul 29, 2012 at 10:49:42PM +0100, David Woodhouse wrote:
> >> + * Some devices may provide ROMs via a source other than the BAR
> >> + */
> >> + if (pdev->rom && pdev->romlen) {
> >> + *size = pdev->romlen;
> >> + return phys_to_virt(pdev->rom);
> >
> > Needs casting. My mistake.
>
> Matthew, are you going to fold this into your patch and repost your
> series, or is this a logically separate issue?

I can fold it in.

--
Matthew Garrett | [email protected]