2022-10-24 12:41:17

by Heiko Thiery

[permalink] [raw]
Subject: [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc

With that delay U-Boot is not able to store the environment variables in
the SD card. Since the delay is not required it can be remove.

Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)

Signed-off-by: Heiko Thiery <[email protected]>
---
v3:
- Improve commit message and explain why it is a fix (thanks to Fabio)

v2:
- add Fixes tag

arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
index a91c136797f6..21442e04a632 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
+++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
@@ -51,7 +51,6 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
- off-on-delay-us = <20000>;
enable-active-high;
};
};
--
2.30.2


2022-10-24 14:13:18

by Fabio Estevam

[permalink] [raw]
Subject: Re: [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc

Hi Heiko,

On Mon, Oct 24, 2022 at 8:54 AM Heiko Thiery <[email protected]> wrote:
>
> With that delay U-Boot is not able to store the environment variables in
> the SD card. Since the delay is not required it can be remove.
>
> Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)
>
> Signed-off-by: Heiko Thiery <[email protected]>
> ---
> v3:
> - Improve commit message and explain why it is a fix (thanks to Fabio)

Reviewed-by: Fabio Estevam <[email protected]>

2022-10-24 14:55:12

by Heiko Thiery

[permalink] [raw]
Subject: Re: [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc

Hi Marco,

Am Mo., 24. Okt. 2022 um 14:34 Uhr schrieb Marco Felsch
<[email protected]>:
>
> Hi Heiko,
>
> On 22-10-24, Heiko Thiery wrote:
> > With that delay U-Boot is not able to store the environment variables in
> > the SD card. Since the delay is not required it can be remove.
>
> Now I'm curious, since this doesn't tell us the why, it just tell us
> about the end result. I'm asking because the NXP EVKs have an issue with
> the sd-card power line capacity and we need this delay to reach a level
> which is marked as low within the sd-spec.

I must admit that I do not know at all why this entry was made. I have
now looked at the dtbs of the imx8 EVKs and except for imx8dxl-evk.dts
I see no delay here.

--
Heiko

> Regards,
> Marco
>
>
> > Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)
> >
> > Signed-off-by: Heiko Thiery <[email protected]>
> > ---
> > v3:
> > - Improve commit message and explain why it is a fix (thanks to Fabio)
> >
> > v2:
> > - add Fixes tag
> >
> > arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> > index a91c136797f6..21442e04a632 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> > @@ -51,7 +51,6 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
> > regulator-min-microvolt = <3300000>;
> > regulator-max-microvolt = <3300000>;
> > gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> > - off-on-delay-us = <20000>;
> > enable-active-high;
> > };
> > };
> > --
> > 2.30.2
> >
> >

2022-10-24 15:00:25

by Marco Felsch

[permalink] [raw]
Subject: Re: [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc

Hi Heiko,

On 22-10-24, Heiko Thiery wrote:
> With that delay U-Boot is not able to store the environment variables in
> the SD card. Since the delay is not required it can be remove.

Now I'm curious, since this doesn't tell us the why, it just tell us
about the end result. I'm asking because the NXP EVKs have an issue with
the sd-card power line capacity and we need this delay to reach a level
which is marked as low within the sd-spec.

Regards,
Marco


> Fixes: 5dbadc848259 (arm64: dts: fsl: add support for Kontron pitx-imx8m board)
>
> Signed-off-by: Heiko Thiery <[email protected]>
> ---
> v3:
> - Improve commit message and explain why it is a fix (thanks to Fabio)
>
> v2:
> - add Fixes tag
>
> arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> index a91c136797f6..21442e04a632 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-kontron-pitx-imx8m.dts
> @@ -51,7 +51,6 @@ reg_usdhc2_vmmc: regulator-usdhc2-vmmc {
> regulator-min-microvolt = <3300000>;
> regulator-max-microvolt = <3300000>;
> gpio = <&gpio2 19 GPIO_ACTIVE_HIGH>;
> - off-on-delay-us = <20000>;
> enable-active-high;
> };
> };
> --
> 2.30.2
>
>

2022-10-24 15:07:19

by Marco Felsch

[permalink] [raw]
Subject: Re: [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc

On 22-10-24, Heiko Thiery wrote:
> Hi Marco,
>
> Am Mo., 24. Okt. 2022 um 14:34 Uhr schrieb Marco Felsch
> <[email protected]>:
> >
> > Hi Heiko,
> >
> > On 22-10-24, Heiko Thiery wrote:
> > > With that delay U-Boot is not able to store the environment variables in
> > > the SD card. Since the delay is not required it can be remove.
> >
> > Now I'm curious, since this doesn't tell us the why, it just tell us
> > about the end result. I'm asking because the NXP EVKs have an issue with
> > the sd-card power line capacity and we need this delay to reach a level
> > which is marked as low within the sd-spec.
>
> I must admit that I do not know at all why this entry was made. I have
> now looked at the dtbs of the imx8 EVKs and except for imx8dxl-evk.dts
> I see no delay here.

Please see <[email protected]>, they will
be added.

Regards,
Marco

2022-10-24 15:58:08

by Heiko Thiery

[permalink] [raw]
Subject: Re: [PATCH v3] arm64: dts: imx8mq-kontron-pitx-imx8m: remove off-on-delay-us for regulator-usdhc2-vmmc

Hi Marco,

Am Mo., 24. Okt. 2022 um 14:58 Uhr schrieb Marco Felsch
<[email protected]>:
>
> On 22-10-24, Heiko Thiery wrote:
> > Hi Marco,
> >
> > Am Mo., 24. Okt. 2022 um 14:34 Uhr schrieb Marco Felsch
> > <[email protected]>:
> > >
> > > Hi Heiko,
> > >
> > > On 22-10-24, Heiko Thiery wrote:
> > > > With that delay U-Boot is not able to store the environment variables in
> > > > the SD card. Since the delay is not required it can be remove.
> > >
> > > Now I'm curious, since this doesn't tell us the why, it just tell us
> > > about the end result. I'm asking because the NXP EVKs have an issue with
> > > the sd-card power line capacity and we need this delay to reach a level
> > > which is marked as low within the sd-spec.
> >
> > I must admit that I do not know at all why this entry was made. I have
> > now looked at the dtbs of the imx8 EVKs and except for imx8dxl-evk.dts
> > I see no delay here.
>
> Please see <[email protected]>, they will
> be added.

I think I have to re-check that and especially why U-Boot is not able
with that setting to access the SD card for writing the environment.

Thanks!

>
> Regards,
> Marco