2024-03-14 11:27:28

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] arm64: dts: qcom: apq8016-sbc: correct GPIO LEDs node names

Individual LEDs in a GPIO LEDs device node are not addressable, thus
unit address is not correct.

dtc is also not happy:

Warning (unit_address_vs_reg): /leds/led@5: node has a unit name, but no reg or ranges property

Reported-by: Sumit Garg <[email protected]>
Closes: https://lore.kernel.org/all/CAFA6WYNRwF7GqhBk2B7i-deT3aLxNQckhnOasjip2TYm4HZgAw@mail.gmail.com/
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
index 9ffad7d1f2b6..aba08424aa38 100644
--- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
+++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
@@ -91,7 +91,7 @@ leds {

compatible = "gpio-leds";

- led@1 {
+ led-1 {
label = "apq8016-sbc:green:user1";
function = LED_FUNCTION_HEARTBEAT;
color = <LED_COLOR_ID_GREEN>;
@@ -100,7 +100,7 @@ led@1 {
default-state = "off";
};

- led@2 {
+ led-2 {
label = "apq8016-sbc:green:user2";
function = LED_FUNCTION_DISK_ACTIVITY;
color = <LED_COLOR_ID_GREEN>;
@@ -109,7 +109,7 @@ led@2 {
default-state = "off";
};

- led@3 {
+ led-3 {
label = "apq8016-sbc:green:user3";
function = LED_FUNCTION_DISK_ACTIVITY;
color = <LED_COLOR_ID_GREEN>;
@@ -118,7 +118,7 @@ led@3 {
default-state = "off";
};

- led@4 {
+ led-4 {
label = "apq8016-sbc:green:user4";
color = <LED_COLOR_ID_GREEN>;
gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
@@ -127,7 +127,7 @@ led@4 {
default-state = "off";
};

- led@5 {
+ led-5 {
label = "apq8016-sbc:yellow:wlan";
function = LED_FUNCTION_WLAN;
color = <LED_COLOR_ID_YELLOW>;
@@ -136,7 +136,7 @@ led@5 {
default-state = "off";
};

- led@6 {
+ led-6 {
label = "apq8016-sbc:blue:bt";
function = LED_FUNCTION_BLUETOOTH;
color = <LED_COLOR_ID_BLUE>;
--
2.34.1



2024-03-14 11:30:51

by Sumit Garg

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: apq8016-sbc: correct GPIO LEDs node names

On Thu, 14 Mar 2024 at 16:57, Krzysztof Kozlowski
<[email protected]> wrote:
>
> Individual LEDs in a GPIO LEDs device node are not addressable, thus
> unit address is not correct.
>
> dtc is also not happy:
>
> Warning (unit_address_vs_reg): /leds/led@5: node has a unit name, but no reg or ranges property
>
> Reported-by: Sumit Garg <[email protected]>
> Closes: https://lore.kernel.org/all/CAFA6WYNRwF7GqhBk2B7i-deT3aLxNQckhnOasjip2TYm4HZgAw@mail.gmail.com/
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>

Reviewed-by: Sumit Garg <[email protected]>

-Sumit

> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> index 9ffad7d1f2b6..aba08424aa38 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> @@ -91,7 +91,7 @@ leds {
>
> compatible = "gpio-leds";
>
> - led@1 {
> + led-1 {
> label = "apq8016-sbc:green:user1";
> function = LED_FUNCTION_HEARTBEAT;
> color = <LED_COLOR_ID_GREEN>;
> @@ -100,7 +100,7 @@ led@1 {
> default-state = "off";
> };
>
> - led@2 {
> + led-2 {
> label = "apq8016-sbc:green:user2";
> function = LED_FUNCTION_DISK_ACTIVITY;
> color = <LED_COLOR_ID_GREEN>;
> @@ -109,7 +109,7 @@ led@2 {
> default-state = "off";
> };
>
> - led@3 {
> + led-3 {
> label = "apq8016-sbc:green:user3";
> function = LED_FUNCTION_DISK_ACTIVITY;
> color = <LED_COLOR_ID_GREEN>;
> @@ -118,7 +118,7 @@ led@3 {
> default-state = "off";
> };
>
> - led@4 {
> + led-4 {
> label = "apq8016-sbc:green:user4";
> color = <LED_COLOR_ID_GREEN>;
> gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
> @@ -127,7 +127,7 @@ led@4 {
> default-state = "off";
> };
>
> - led@5 {
> + led-5 {
> label = "apq8016-sbc:yellow:wlan";
> function = LED_FUNCTION_WLAN;
> color = <LED_COLOR_ID_YELLOW>;
> @@ -136,7 +136,7 @@ led@5 {
> default-state = "off";
> };
>
> - led@6 {
> + led-6 {
> label = "apq8016-sbc:blue:bt";
> function = LED_FUNCTION_BLUETOOTH;
> color = <LED_COLOR_ID_BLUE>;
> --
> 2.34.1
>

2024-03-14 11:31:32

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: apq8016-sbc: correct GPIO LEDs node names

On 14/03/2024 12:26, Krzysztof Kozlowski wrote:
> Individual LEDs in a GPIO LEDs device node are not addressable, thus
> unit address is not correct.
>
> dtc is also not happy:
>
> Warning (unit_address_vs_reg): /leds/led@5: node has a unit name, but no reg or ranges property
>
> Reported-by: Sumit Garg <[email protected]>
> Closes: https://lore.kernel.org/all/CAFA6WYNRwF7GqhBk2B7i-deT3aLxNQckhnOasjip2TYm4HZgAw@mail.gmail.com/
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/apq8016-sbc.dts | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> index 9ffad7d1f2b6..aba08424aa38 100644
> --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dts
> @@ -91,7 +91,7 @@ leds {
>
> compatible = "gpio-leds";
>
> - led@1 {
> + led-1 {
> label = "apq8016-sbc:green:user1";
> function = LED_FUNCTION_HEARTBEAT;
> color = <LED_COLOR_ID_GREEN>;
> @@ -100,7 +100,7 @@ led@1 {
> default-state = "off";
> };
>
> - led@2 {
> + led-2 {
> label = "apq8016-sbc:green:user2";
> function = LED_FUNCTION_DISK_ACTIVITY;
> color = <LED_COLOR_ID_GREEN>;
> @@ -109,7 +109,7 @@ led@2 {
> default-state = "off";
> };
>
> - led@3 {
> + led-3 {
> label = "apq8016-sbc:green:user3";
> function = LED_FUNCTION_DISK_ACTIVITY;
> color = <LED_COLOR_ID_GREEN>;
> @@ -118,7 +118,7 @@ led@3 {
> default-state = "off";
> };
>
> - led@4 {
> + led-4 {
> label = "apq8016-sbc:green:user4";
> color = <LED_COLOR_ID_GREEN>;
> gpios = <&pm8916_gpios 2 GPIO_ACTIVE_HIGH>;
> @@ -127,7 +127,7 @@ led@4 {
> default-state = "off";
> };
>
> - led@5 {
> + led-5 {
> label = "apq8016-sbc:yellow:wlan";
> function = LED_FUNCTION_WLAN;
> color = <LED_COLOR_ID_YELLOW>;
> @@ -136,7 +136,7 @@ led@5 {
> default-state = "off";
> };
>
> - led@6 {
> + led-6 {
> label = "apq8016-sbc:blue:bt";
> function = LED_FUNCTION_BLUETOOTH;
> color = <LED_COLOR_ID_BLUE>;

Reviewed-by: Neil Armstrong <[email protected]>

2024-04-04 21:25:35

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: qcom: apq8016-sbc: correct GPIO LEDs node names


On Thu, 14 Mar 2024 12:26:57 +0100, Krzysztof Kozlowski wrote:
> Individual LEDs in a GPIO LEDs device node are not addressable, thus
> unit address is not correct.
>
> dtc is also not happy:
>
> Warning (unit_address_vs_reg): /leds/led@5: node has a unit name, but no reg or ranges property
>
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: apq8016-sbc: correct GPIO LEDs node names
commit: 216e62744b91c9716228fe13f564e83381a1342e

Best regards,
--
Bjorn Andersson <[email protected]>