2021-09-22 00:06:43

by Anand Moon

Subject: [PATCHv3] regulator: pwm-regulator: Make use of the helper function dev_err_probe()

devm_pwm_get() can return -EPROBE_DEFER if the pwm regulator is not
ready yet. Use dev_err_probe() for pwm regulator resources
to indicate the deferral reason when waiting for the
resource to come up.

Cc: Martin Blumenstingl <[email protected]>
Signed-off-by: Anand Moon <[email protected]>
---
V2 - Fix the return message and drop the FIX tag in commit.
V1 - Fix the wrong probe defer for devm_regulator_register.
- Fix the commit message.
---
drivers/regulator/pwm-regulator.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/regulator/pwm-regulator.c b/drivers/regulator/pwm-regulator.c
index 7629476d94ae..9e2784ce8f67 100644
--- a/drivers/regulator/pwm-regulator.c
+++ b/drivers/regulator/pwm-regulator.c
@@ -353,13 +353,8 @@ static int pwm_regulator_probe(struct platform_device *pdev)

drvdata->pwm = devm_pwm_get(&pdev->dev, NULL);
if (IS_ERR(drvdata->pwm)) {
- ret = PTR_ERR(drvdata->pwm);
- if (ret == -EPROBE_DEFER)
- dev_dbg(&pdev->dev,
- "Failed to get PWM, deferring probe\n");
- else
- dev_err(&pdev->dev, "Failed to get PWM: %d\n", ret);
- return ret;
+ return dev_err_probe(&pdev->dev, PTR_ERR(drvdata->pwm),
+ "Failed to get PWM\n");
}

if (init_data->constraints.boot_on || init_data->constraints.always_on)
--
2.33.0

2021-09-25 17:14:16

by Martin Blumenstingl

Subject: Re: [PATCHv3] regulator: pwm-regulator: Make use of the helper function dev_err_probe()

Hi Anand,

On Tue, Sep 21, 2021 at 11:27 PM Anand Moon <[email protected]> wrote:
[...]
> @@ -353,13 +353,8 @@ static int pwm_regulator_probe(struct platform_device *pdev)
>
> drvdata->pwm = devm_pwm_get(&pdev->dev, NULL);
> if (IS_ERR(drvdata->pwm)) {
> - ret = PTR_ERR(drvdata->pwm);
> - if (ret == -EPROBE_DEFER)
> - dev_dbg(&pdev->dev,
> - "Failed to get PWM, deferring probe\n");
> - else
> - dev_err(&pdev->dev, "Failed to get PWM: %d\n", ret);
> - return ret;
> + return dev_err_probe(&pdev->dev, PTR_ERR(drvdata->pwm),
> + "Failed to get PWM\n");
> }
From functional perspective you're patch is looking good now.
I just noticed that the coding-style in the pwm-regulator driver is
not not use any curly brackets for the if block when there's only one
statement

with the curly brackets removed (and if there are no other changes to
this patch) then you can add my:
Acked-by: Martin Blumenstingl <[email protected]>


Best regards,
Martin

2021-09-25 17:35:28

by Anand Moon

Subject: Re: [PATCHv3] regulator: pwm-regulator: Make use of the helper function dev_err_probe()

Hi Martin,

On Sat, 25 Sept 2021 at 22:42, Martin Blumenstingl
<[email protected]> wrote:
>
> Hi Anand,
>
> On Tue, Sep 21, 2021 at 11:27 PM Anand Moon <[email protected]> wrote:
> [...]
> > @@ -353,13 +353,8 @@ static int pwm_regulator_probe(struct platform_device *pdev)
> >
> > drvdata->pwm = devm_pwm_get(&pdev->dev, NULL);
> > if (IS_ERR(drvdata->pwm)) {
> > - ret = PTR_ERR(drvdata->pwm);
> > - if (ret == -EPROBE_DEFER)
> > - dev_dbg(&pdev->dev,
> > - "Failed to get PWM, deferring probe\n");
> > - else
> > - dev_err(&pdev->dev, "Failed to get PWM: %d\n", ret);
> > - return ret;
> > + return dev_err_probe(&pdev->dev, PTR_ERR(drvdata->pwm),
> > + "Failed to get PWM\n");
> > }
> From functional perspective you're patch is looking good now.
> I just noticed that the coding-style in the pwm-regulator driver is
> not not use any curly brackets for the if block when there's only one
> statement
>
> with the curly brackets removed (and if there are no other changes to
> this patch) then you can add my:
> Acked-by: Martin Blumenstingl <[email protected]>
>
Thanks, I will update the patch in the next version.
>
> Best regards,
> Martin

Thanks
-Anand