2023-06-12 18:46:07

by Stephen Boyd

Subject: [PATCH] clk: meson: a1: Staticize rtc clk

Sparse rightly complains that this symbol is supposed to be static.

Cc: Jian Hu <[email protected]>
Cc: Dmitry Rokosov <[email protected]>
Cc: Martin Blumenstingl <[email protected]>
Cc: Jerome Brunet <[email protected]>
Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver")
Signed-off-by: Stephen Boyd <[email protected]>
---
drivers/clk/meson/a1-peripherals.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/meson/a1-peripherals.c b/drivers/clk/meson/a1-peripherals.c
index b320134fefeb..75dfae210fe5 100644
--- a/drivers/clk/meson/a1-peripherals.c
+++ b/drivers/clk/meson/a1-peripherals.c
@@ -218,7 +218,7 @@ static struct clk_regmap rtc_32k_sel = {
},
};

-struct clk_regmap rtc = {
+static struct clk_regmap rtc = {
.data = &(struct clk_regmap_gate_data){
.offset = RTC_BY_OSCIN_CTRL0,
.bit_idx = 30,
--
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git

2023-06-12 20:18:19

by Jerome Brunet

Subject: Re: [PATCH] clk: meson: a1: Staticize rtc clk

On Mon 12 Jun 2023 at 11:23, Stephen Boyd <[email protected]> wrote:

> Sparse rightly complains that this symbol is supposed to be static.
>
> Cc: Jian Hu <[email protected]>
> Cc: Dmitry Rokosov <[email protected]>
> Cc: Martin Blumenstingl <[email protected]>
> Cc: Jerome Brunet <[email protected]>
> Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver")
> Signed-off-by: Stephen Boyd <[email protected]>

Reviewed-by: Jerome Brunet <[email protected]>

Sorry this got through.

> ---
> drivers/clk/meson/a1-peripherals.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/a1-peripherals.c b/drivers/clk/meson/a1-peripherals.c
> index b320134fefeb..75dfae210fe5 100644
> --- a/drivers/clk/meson/a1-peripherals.c
> +++ b/drivers/clk/meson/a1-peripherals.c
> @@ -218,7 +218,7 @@ static struct clk_regmap rtc_32k_sel = {
> },
> };
>
> -struct clk_regmap rtc = {
> +static struct clk_regmap rtc = {
> .data = &(struct clk_regmap_gate_data){
> .offset = RTC_BY_OSCIN_CTRL0,
> .bit_idx = 30,

2023-06-12 20:35:20

by Martin Blumenstingl

Subject: Re: [PATCH] clk: meson: a1: Staticize rtc clk

On Mon, Jun 12, 2023 at 8:23 PM Stephen Boyd <[email protected]> wrote:
>
> Sparse rightly complains that this symbol is supposed to be static.
>
> Cc: Jian Hu <[email protected]>
> Cc: Dmitry Rokosov <[email protected]>
> Cc: Martin Blumenstingl <[email protected]>
> Cc: Jerome Brunet <[email protected]>
> Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver")
> Signed-off-by: Stephen Boyd <[email protected]>
Reviewed-by: Martin Blumenstingl <[email protected]>

Thanks for providing a fix so quickly!

Jerome, I think it's easiest for Stephen to apply this patch directly
to the clock tree.
In my opinion there's no reason against this since our own patch queue is empty.



Best regards,
Martin

2023-06-12 21:53:51

by Stephen Boyd

Subject: Re: [PATCH] clk: meson: a1: Staticize rtc clk

Quoting Stephen Boyd (2023-06-12 11:23:32)
> Sparse rightly complains that this symbol is supposed to be static.
>
> Cc: Jian Hu <[email protected]>
> Cc: Dmitry Rokosov <[email protected]>
> Cc: Martin Blumenstingl <[email protected]>
> Cc: Jerome Brunet <[email protected]>
> Fixes: 84af914404db ("clk: meson: a1: add Amlogic A1 Peripherals clock controller driver")
> Signed-off-by: Stephen Boyd <[email protected]>
> ---

Applied to clk-next