2023-11-20 20:16:35

by Martin Blumenstingl

Subject: Re: [PATCH 2/2] pmdomain: amlogic: meson-ee-pwrc: add support for G12A ISP power domain

Hi Neil,

On Tue, Nov 14, 2023 at 11:19 AM Neil Armstrong
<[email protected]> wrote:
[...]
> +static struct meson_ee_pwrc_mem_domain g12a_pwrc_mem_isp[] = {
> + { G12A_HHI_ISP_MEM_PD_REG0, GENMASK(31, 0) },
> + { G12A_HHI_ISP_MEM_PD_REG0, GENMASK(31, 0) },
I expected this second line to use G12A_HHI_ISP_MEM_PD_REG1 (note the
number at the end: 0 vs 1)
Is this correct?


Best regards,
Martin

2023-11-21 11:05:14

by Neil Armstrong

Subject: Re: [PATCH 2/2] pmdomain: amlogic: meson-ee-pwrc: add support for G12A ISP power domain

On 20/11/2023 21:15, Martin Blumenstingl wrote:
> Hi Neil,
>
> On Tue, Nov 14, 2023 at 11:19 AM Neil Armstrong
> <[email protected]> wrote:
> [...]
>> +static struct meson_ee_pwrc_mem_domain g12a_pwrc_mem_isp[] = {
>> + { G12A_HHI_ISP_MEM_PD_REG0, GENMASK(31, 0) },
>> + { G12A_HHI_ISP_MEM_PD_REG0, GENMASK(31, 0) },
> I expected this second line to use G12A_HHI_ISP_MEM_PD_REG1 (note the
> number at the end: 0 vs 1)
> Is this correct?

Indeed you're right, let me fix it in a v2,

Thanks,
Neil

>
>
> Best regards,
> Martin