On Fri, Aug 25, 2023 at 12:19 PM Stanislaw Gruszka
<[email protected]> wrote:
>
> On Wed, Aug 23, 2023 at 12:23:08AM +0000, Justin Stitt wrote:
> > `strncpy` is deprecated for use on NUL-terminated destination strings [1].
> >
> > A suitable replacement is `strscpy` [2] due to the fact that it
> > guarantees NUL-termination on its destination buffer argument which is
> > _not_ the case for `strncpy`!
> >
> > There is likely no bug happening in this case since HL_STR_MAX is
> > strictly larger than all source strings. Nonetheless, prefer a safer and
> > more robust interface.
> >
> > It should also be noted that `strscpy` will not pad like `strncpy`. If
> > this NUL-padding behavior is _required_ we should use `strscpy_pad`
> > instead of `strscpy`.
> >
> > Link: http://www.kernel.org/doc/html/latest/process/deprecated.html#strncpy-on-nul-terminated-strings[1]
> > Link: https://manpages.debian.org/testing/linux-manual-4.8/strscpy.9.en.html [2]
> > Link: https://github.com/KSPP/linux/issues/90
> > Cc: [email protected]
> > Signed-off-by: Justin Stitt <[email protected]>
> Reviewed-by: Stanislaw Gruszka <[email protected]>
>
Applied to -next
Thanks,
Oded