2023-06-16 12:57:54

by Juerg Haefliger

Subject: [PATCH] habanalabs/gaudi: Add MODULE_FIRMWARE macros

The module loads firmware so add MODULE_FIRMWARE macros to provide that
information via modinfo.

Signed-off-by: Juerg Haefliger <[email protected]>
---
drivers/accel/habanalabs/gaudi/gaudi.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/accel/habanalabs/gaudi/gaudi.c b/drivers/accel/habanalabs/gaudi/gaudi.c
index a29aa8f7b6f3..cd034e98128a 100644
--- a/drivers/accel/habanalabs/gaudi/gaudi.c
+++ b/drivers/accel/habanalabs/gaudi/gaudi.c
@@ -63,6 +63,10 @@
#define GAUDI_LINUX_FW_FILE "habanalabs/gaudi/gaudi-fit.itb"
#define GAUDI_TPC_FW_FILE "habanalabs/gaudi/gaudi_tpc.bin"

+MODULE_FIRMWARE(GAUDI_BOOT_FIT_FILE);
+MODULE_FIRMWARE(GAUDI_LINUX_FW_FILE);
+MODULE_FIRMWARE(GAUDI_TPC_FW_FILE);
+
#define GAUDI_DMA_POOL_BLK_SIZE 0x100 /* 256 bytes */

#define GAUDI_RESET_TIMEOUT_MSEC 2000 /* 2000ms */
--
2.37.2

2023-07-03 12:50:16

by Oded Gabbay

Subject: Re: [PATCH] habanalabs/gaudi: Add MODULE_FIRMWARE macros

On Fri, Jun 16, 2023 at 3:16 PM Juerg Haefliger
<[email protected]> wrote:
>
> The module loads firmware so add MODULE_FIRMWARE macros to provide that
> information via modinfo.
>
> Signed-off-by: Juerg Haefliger <[email protected]>
> ---
> drivers/accel/habanalabs/gaudi/gaudi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/accel/habanalabs/gaudi/gaudi.c b/drivers/accel/habanalabs/gaudi/gaudi.c
> index a29aa8f7b6f3..cd034e98128a 100644
> --- a/drivers/accel/habanalabs/gaudi/gaudi.c
> +++ b/drivers/accel/habanalabs/gaudi/gaudi.c
> @@ -63,6 +63,10 @@
> #define GAUDI_LINUX_FW_FILE "habanalabs/gaudi/gaudi-fit.itb"
> #define GAUDI_TPC_FW_FILE "habanalabs/gaudi/gaudi_tpc.bin"
>
> +MODULE_FIRMWARE(GAUDI_BOOT_FIT_FILE);
> +MODULE_FIRMWARE(GAUDI_LINUX_FW_FILE);
> +MODULE_FIRMWARE(GAUDI_TPC_FW_FILE);
> +
> #define GAUDI_DMA_POOL_BLK_SIZE 0x100 /* 256 bytes */
>
> #define GAUDI_RESET_TIMEOUT_MSEC 2000 /* 2000ms */
> --
> 2.37.2
>
Reviewed-by: Oded Gabbay <[email protected]>
Applied to -next.
Thanks,
Oded