2020-07-04 19:53:08

by Omer Shpigelman

Subject: [PATCH] habanalbas: rephrase error message

Rephrase F/W error message to make it more understandable to ordinary
users.

Signed-off-by: Omer Shpigelman <[email protected]>
---
drivers/misc/habanalabs/firmware_if.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/misc/habanalabs/firmware_if.c b/drivers/misc/habanalabs/firmware_if.c
index baf790cf4b78..171baa2b56b0 100644
--- a/drivers/misc/habanalabs/firmware_if.c
+++ b/drivers/misc/habanalabs/firmware_if.c
@@ -566,7 +566,8 @@ int hl_fw_init_cpu(struct hl_device *hdev, u32 cpu_boot_status_reg,
"Device reports FIT image is corrupted\n");
else
dev_err(hdev->dev,
- "Device failed to load, %d\n", status);
+ "Failed to load firmware to device, %d\n",
+ status);

rc = -EIO;
goto out;
--
2.17.1

2020-07-04 21:40:51

by Oded Gabbay

Subject: Re: [PATCH] habanalbas: rephrase error message

On Sat, Jul 4, 2020 at 10:51 PM Omer Shpigelman <[email protected]> wrote:
>
> Rephrase F/W error message to make it more understandable to ordinary
> users.
>
> Signed-off-by: Omer Shpigelman <[email protected]>
> ---
> drivers/misc/habanalabs/firmware_if.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/firmware_if.c b/drivers/misc/habanalabs/firmware_if.c
> index baf790cf4b78..171baa2b56b0 100644
> --- a/drivers/misc/habanalabs/firmware_if.c
> +++ b/drivers/misc/habanalabs/firmware_if.c
> @@ -566,7 +566,8 @@ int hl_fw_init_cpu(struct hl_device *hdev, u32 cpu_boot_status_reg,
> "Device reports FIT image is corrupted\n");
> else
> dev_err(hdev->dev,
> - "Device failed to load, %d\n", status);
> + "Failed to load firmware to device, %d\n",
> + status);
>
> rc = -EIO;
> goto out;
> --
> 2.17.1
>

This patch is:
Reviewed-by: Oded Gabbay <[email protected]>