2020-07-06 00:51:59

by Chris Healy

Subject: [PATCH] ARM: dts: vf610-zii-dev-rev-c.dts: Configure fibre port to 1000BaseX

The SFF soldered onto the board expects the port to use 1000BaseX. It
makes no sense to have the port set to SGMII, since it doesn't even
support that mode.

Signed-off-by: Chris Healy <[email protected]>
---
arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
index 778e02c000d1..de79dcfd32e6 100644
--- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
+++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
@@ -164,7 +164,7 @@
port@9 {
reg = <9>;
label = "sff2";
- phy-mode = "sgmii";
+ phy-mode = "1000base-x";
managed = "in-band-status";
sfp = <&sff2>;
};
--
2.21.3

2020-07-08 18:44:02

by Fabio Estevam

Subject: Re: [PATCH] ARM: dts: vf610-zii-dev-rev-c.dts: Configure fibre port to 1000BaseX

Hi Chris,

In the Subject you could remove the .dts from the dts name:

ARM: dts: vf610-zii-dev-rev-c: Configure fibre port to 1000BaseX

On Sun, Jul 5, 2020 at 9:51 PM Chris Healy <[email protected]> wrote:
>
> The SFF soldered onto the board expects the port to use 1000BaseX. It
> makes no sense to have the port set to SGMII, since it doesn't even
> support that mode.
>
> Signed-off-by: Chris Healy <[email protected]>
> ---
> arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> index 778e02c000d1..de79dcfd32e6 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> @@ -164,7 +164,7 @@
> port@9 {
> reg = <9>;
> label = "sff2";
> - phy-mode = "sgmii";
> + phy-mode = "1000base-x";

Looks like tabs were converted to spaces.

2020-07-08 18:53:24

by Chris Healy

Subject: Re: [PATCH] ARM: dts: vf610-zii-dev-rev-c.dts: Configure fibre port to 1000BaseX

On Wed, Jul 8, 2020 at 11:41 AM Fabio Estevam <[email protected]> wrote:
>
> Hi Chris,
>
> In the Subject you could remove the .dts from the dts name:
>
> ARM: dts: vf610-zii-dev-rev-c: Configure fibre port to 1000BaseX
>
> On Sun, Jul 5, 2020 at 9:51 PM Chris Healy <[email protected]> wrote:
> >
> > The SFF soldered onto the board expects the port to use 1000BaseX. It
> > makes no sense to have the port set to SGMII, since it doesn't even
> > support that mode.
> >
> > Signed-off-by: Chris Healy <[email protected]>
> > ---
> > arch/arm/boot/dts/vf610-zii-dev-rev-c.dts | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > index 778e02c000d1..de79dcfd32e6 100644
> > --- a/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > +++ b/arch/arm/boot/dts/vf610-zii-dev-rev-c.dts
> > @@ -164,7 +164,7 @@
> > port@9 {
> > reg = <9>;
> > label = "sff2";
> > - phy-mode = "sgmii";
> > + phy-mode = "1000base-x";
>
> Looks like tabs were converted to spaces.

I'll make both changes and submit a v2, thanks.