2021-06-29 12:50:34

by Harini Katakam

Subject: [PATCH] dmaengine: pl330: Typecast with enum to fix the coverity warning

From: Shravya Kumbham <[email protected]>

Typecast the flags and flg variables with (enum dma_ctrl_flags) in
pl330_prep_dma_cyclic, pl330_prep_dma_memcpy and pl330_prep_slave_sg
functions to fix the coverity warning.

Addresses-Coverity: Event mixed_enum_type.
Signed-off-by: Shravya Kumbham <[email protected]>
Signed-off-by: Harini Katakam <[email protected]>
Reviewed-by: Radhey Shyam Pandey <[email protected]>
---
drivers/dma/pl330.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 110de8a60058..35afbad2e1a7 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2752,7 +2752,7 @@ static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic(
return NULL;

pch->cyclic = true;
- desc->txd.flags = flags;
+ desc->txd.flags = (enum dma_ctrl_flags)flags;

return &desc->txd;
}
@@ -2804,7 +2804,7 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,

desc->bytes_requested = len;

- desc->txd.flags = flags;
+ desc->txd.flags = (enum dma_ctrl_flags)flags;

return &desc->txd;
}
@@ -2889,7 +2889,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
}

/* Return the last desc in the chain */
- desc->txd.flags = flg;
+ desc->txd.flags = (enum dma_ctrl_flags)flg;
return &desc->txd;
}

--
2.17.1

2021-07-28 07:03:44

by Vinod Koul

Subject: Re: [PATCH] dmaengine: pl330: Typecast with enum to fix the coverity warning

On 29-06-21, 16:07, Harini Katakam wrote:
> From: Shravya Kumbham <[email protected]>
>
> Typecast the flags and flg variables with (enum dma_ctrl_flags) in
> pl330_prep_dma_cyclic, pl330_prep_dma_memcpy and pl330_prep_slave_sg
> functions to fix the coverity warning.
>
> Addresses-Coverity: Event mixed_enum_type.
> Signed-off-by: Shravya Kumbham <[email protected]>
> Signed-off-by: Harini Katakam <[email protected]>
> Reviewed-by: Radhey Shyam Pandey <[email protected]>
> ---
> drivers/dma/pl330.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
> index 110de8a60058..35afbad2e1a7 100644
> --- a/drivers/dma/pl330.c
> +++ b/drivers/dma/pl330.c
> @@ -2752,7 +2752,7 @@ static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic(
> return NULL;
>
> pch->cyclic = true;
> - desc->txd.flags = flags;
> + desc->txd.flags = (enum dma_ctrl_flags)flags;

Does this driver use the txd.flags?

>
> return &desc->txd;
> }
> @@ -2804,7 +2804,7 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
>
> desc->bytes_requested = len;
>
> - desc->txd.flags = flags;
> + desc->txd.flags = (enum dma_ctrl_flags)flags;
>
> return &desc->txd;
> }
> @@ -2889,7 +2889,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
> }
>
> /* Return the last desc in the chain */
> - desc->txd.flags = flg;
> + desc->txd.flags = (enum dma_ctrl_flags)flg;
> return &desc->txd;
> }
>
> --
> 2.17.1

--
~Vinod

2021-09-14 08:13:41

by Harini Katakam

Subject: Re: [PATCH] dmaengine: pl330: Typecast with enum to fix the coverity warning

Hi Vinod,

<snip>
> > pch->cyclic = true;
> > - desc->txd.flags = flags;
> > + desc->txd.flags = (enum dma_ctrl_flags)flags;
>
> Does this driver use the txd.flags?

Sorry for the delayed response. This flag is not used and I'm working
on another patch to remove it.

Regards,
Harini