2018-07-06 05:15:32

by Masahiro Yamada

Subject: [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag

I refactored the include directives under include/drm/ some time ago.
This flag is unneeded.

Signed-off-by: Masahiro Yamada <[email protected]>
---

drivers/gpu/drm/scheduler/Makefile | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/scheduler/Makefile b/drivers/gpu/drm/scheduler/Makefile
index bd0377c..7665883 100644
--- a/drivers/gpu/drm/scheduler/Makefile
+++ b/drivers/gpu/drm/scheduler/Makefile
@@ -20,7 +20,6 @@
# OTHER DEALINGS IN THE SOFTWARE.
#
#
-ccflags-y := -Iinclude/drm
gpu-sched-y := gpu_scheduler.o sched_fence.o

obj-$(CONFIG_DRM_SCHED) += gpu-sched.o
--
2.7.4

2018-07-28 02:46:00

by Masahiro Yamada

Subject: Re: [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag

Hi.

2018-07-06 14:12 GMT+09:00 Masahiro Yamada <[email protected]>:
> I refactored the include directives under include/drm/ some time ago.
> This flag is unneeded.
>
> Signed-off-by: Masahiro Yamada <[email protected]>

Ping?


> ---
>
> drivers/gpu/drm/scheduler/Makefile | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/scheduler/Makefile b/drivers/gpu/drm/scheduler/Makefile
> index bd0377c..7665883 100644
> --- a/drivers/gpu/drm/scheduler/Makefile
> +++ b/drivers/gpu/drm/scheduler/Makefile
> @@ -20,7 +20,6 @@
> # OTHER DEALINGS IN THE SOFTWARE.
> #
> #
> -ccflags-y := -Iinclude/drm
> gpu-sched-y := gpu_scheduler.o sched_fence.o
>
> obj-$(CONFIG_DRM_SCHED) += gpu-sched.o
> --
> 2.7.4
>



--
Best Regards
Masahiro Yamada

2018-07-30 12:51:25

by Nayan Deshmukh

Subject: Re: [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag

On Sat, Jul 28, 2018 at 6:54 PM Masahiro Yamada <
[email protected]> wrote:

> Hi.
>
> 2018-07-06 14:12 GMT+09:00 Masahiro Yamada <[email protected]
> >:
> > I refactored the include directives under include/drm/ some time ago.
> > This flag is unneeded.
> >
>
A minor nit-pick in the commit message, something like "With the refactored
include directives under include/drm, this flag is uneeded." might be
better.

> > Signed-off-by: Masahiro Yamada <[email protected]>
>
With or without that the patch is Acked-by: Nayan Deshmukh <
[email protected]>

Regards,
Nayan Deshmukh

>
> Ping?
>
>
> > ---
> >
> > drivers/gpu/drm/scheduler/Makefile | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/scheduler/Makefile
> b/drivers/gpu/drm/scheduler/Makefile
> > index bd0377c..7665883 100644
> > --- a/drivers/gpu/drm/scheduler/Makefile
> > +++ b/drivers/gpu/drm/scheduler/Makefile
> > @@ -20,7 +20,6 @@
> > # OTHER DEALINGS IN THE SOFTWARE.
> > #
> > #
> > -ccflags-y := -Iinclude/drm
> > gpu-sched-y := gpu_scheduler.o sched_fence.o
> >
> > obj-$(CONFIG_DRM_SCHED) += gpu-sched.o
> > --
> > 2.7.4
> >
>
>
>
> --
> Best Regards
> Masahiro Yamada
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>

2018-07-30 13:11:13

by Christian König

Subject: Re: [PATCH] drm/sched: remove unneeded -Iinclude/drm compiler flag

Am 30.07.2018 um 14:49 schrieb Nayan Deshmukh:
>
>
> On Sat, Jul 28, 2018 at 6:54 PM Masahiro Yamada
> <[email protected] <mailto:[email protected]>>
> wrote:
>
> Hi.
>
> 2018-07-06 14:12 GMT+09:00 Masahiro Yamada
> <[email protected]
> <mailto:[email protected]>>:
> > I refactored the include directives under include/drm/ some time
> ago.
> > This flag is unneeded.
> >
>
> A minor nit-pick in the commit message, something like "With the
> refactored include directives under include/drm, this flag is
> uneeded." might be better.
>
> > Signed-off-by: Masahiro Yamada <[email protected]
> <mailto:[email protected]>>
>
> With or without that the patch is Acked-by: Nayan Deshmukh
> <[email protected] <mailto:[email protected]>>

I've pushed that patch into our internal branch for scheduler work.

Thanks,
Christian.

>
> Regards,
> Nayan Deshmukh
>
>
> Ping?
>
>
> > ---
> >
> >  drivers/gpu/drm/scheduler/Makefile | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/scheduler/Makefile
> b/drivers/gpu/drm/scheduler/Makefile
> > index bd0377c..7665883 100644
> > --- a/drivers/gpu/drm/scheduler/Makefile
> > +++ b/drivers/gpu/drm/scheduler/Makefile
> > @@ -20,7 +20,6 @@
> >  # OTHER DEALINGS IN THE SOFTWARE.
> >  #
> >  #
> > -ccflags-y := -Iinclude/drm
> >  gpu-sched-y := gpu_scheduler.o sched_fence.o
> >
> >  obj-$(CONFIG_DRM_SCHED) += gpu-sched.o
> > --
> > 2.7.4
> >
>
>
>
> --
> Best Regards
> Masahiro Yamada
> _______________________________________________
> dri-devel mailing list
> [email protected]
> <mailto:[email protected]>
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
>
>
>
> _______________________________________________
> dri-devel mailing list
> [email protected]
> https://lists.freedesktop.org/mailman/listinfo/dri-devel