2021-02-24 09:23:29

by Ikjoon Jang

[permalink] [raw]
Subject: [PATCH] arm64: dts: mt8183: Add power-domains properity to mfgcfg

mfgcfg clock is under MFG_ASYNC power domain

Signed-off-by: Weiyi Lu <[email protected]>
Signed-off-by: Ikjoon Jang <[email protected]>
---

arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
index 5b782a4769e7..3384df5284c0 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
@@ -962,6 +962,7 @@ mfgcfg: syscon@13000000 {
compatible = "mediatek,mt8183-mfgcfg", "syscon";
reg = <0 0x13000000 0 0x1000>;
#clock-cells = <1>;
+ power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_ASYNC>;
};

mmsys: syscon@14000000 {
--
2.30.0.617.g56c4b15f3c-goog


2021-02-24 10:34:28

by Enric Balletbo Serra

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: mt8183: Add power-domains properity to mfgcfg

Hi Ikjoon,

Thank you for your patch.

Missatge de Ikjoon Jang <[email protected]> del dia dc., 24 de febr.
2021 a les 10:21:
>
> mfgcfg clock is under MFG_ASYNC power domain
>
> Signed-off-by: Weiyi Lu <[email protected]>
> Signed-off-by: Ikjoon Jang <[email protected]>
> ---
>
> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> index 5b782a4769e7..3384df5284c0 100644
> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> @@ -962,6 +962,7 @@ mfgcfg: syscon@13000000 {
> compatible = "mediatek,mt8183-mfgcfg", "syscon";
> reg = <0 0x13000000 0 0x1000>;
> #clock-cells = <1>;
> + power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_ASYNC>;

I don't think this will work in mainline, at least, the reference name
should be &spm

Thanks,
Enric
> };
>
> mmsys: syscon@14000000 {
> --
> 2.30.0.617.g56c4b15f3c-goog
>
>
> _______________________________________________
> Linux-mediatek mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-mediatek

2021-04-01 09:42:46

by Matthias Brugger

[permalink] [raw]
Subject: Re: [PATCH] arm64: dts: mt8183: Add power-domains properity to mfgcfg



On 24/02/2021 11:30, Enric Balletbo Serra wrote:
> Hi Ikjoon,
>
> Thank you for your patch.
>
> Missatge de Ikjoon Jang <[email protected]> del dia dc., 24 de febr.
> 2021 a les 10:21:
>>
>> mfgcfg clock is under MFG_ASYNC power domain
>>
>> Signed-off-by: Weiyi Lu <[email protected]>
>> Signed-off-by: Ikjoon Jang <[email protected]>
>> ---
>>
>> arch/arm64/boot/dts/mediatek/mt8183.dtsi | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> index 5b782a4769e7..3384df5284c0 100644
>> --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
>> @@ -962,6 +962,7 @@ mfgcfg: syscon@13000000 {
>> compatible = "mediatek,mt8183-mfgcfg", "syscon";
>> reg = <0 0x13000000 0 0x1000>;
>> #clock-cells = <1>;
>> + power-domains = <&scpsys MT8183_POWER_DOMAIN_MFG_ASYNC>;
>
> I don't think this will work in mainline, at least, the reference name
> should be &spm
>

Correct. Would you mind to resend with the comment from Enric. Apart from that,
patch looks fine to me.

Regards,
Matthias

> Thanks,
> Enric
>> };
>>
>> mmsys: syscon@14000000 {
>> --
>> 2.30.0.617.g56c4b15f3c-goog
>>
>>
>> _______________________________________________
>> Linux-mediatek mailing list
>> [email protected]
>> http://lists.infradead.org/mailman/listinfo/linux-mediatek